Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support fargateTaskRetirementWaitPeriod in ECS account defaults #33422

Closed
moritzzimmer opened this issue Sep 12, 2023 · 5 comments · Fixed by #37018
Closed

[Enhancement]: Support fargateTaskRetirementWaitPeriod in ECS account defaults #33422

moritzzimmer opened this issue Sep 12, 2023 · 5 comments · Fixed by #37018
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@moritzzimmer
Copy link

Description

Support the configuration of fargateTaskRetirementWaitPeriod as an ECS account default. This is already possible using the CLI, see https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-account-settings.html#fargate-retirement-wait-time for details.

Valid values are 0, 7 and 14

Affected Resource(s) and/or Data Source(s)

  • aws_ecs_account_setting_default

Potential Terraform Configuration

No response

References

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-account-settings.html#fargate-retirement-wait-time

Would you like to implement a fix?

None

@moritzzimmer moritzzimmer added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 12, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ecs Issues and PRs that pertain to the ecs service. label Sep 12, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 12, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2023
@acdha
Copy link
Contributor

acdha commented Dec 5, 2023

This is blocked on #33393 which will remove the input validation currently constraining aws_ecs_account_setting_default.value to true or false.

@johnsonaj johnsonaj self-assigned this May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 9, 2024
@johnsonaj johnsonaj assigned nam054 and unassigned johnsonaj May 9, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.50.0 milestone May 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
5 participants