[Bug]: user_name_column and group_name_column blocks are required when they shouldn't be

[jackarmorgie]

Terraform Core Version

1.0.0

AWS Provider Version

5.17.0

Affected Resource(s)

aws_quicksight_dashboard

Expected Behavior

Parameter with dynamic default value to be added to dashboard.

Actual Behavior

Dashboard fails to be updated.

Relevant Error/Panic Output Snippet

│ Error: Insufficient group_name_column blocks
│ 
│   on quicksight.tf line 433, in resource "aws_quicksight_dashboard" "example":
│  433:           dynamic_value {
│ 
│ At least 1 "group_name_column" blocks are required.

Terraform Configuration Files

resource "aws_quicksight_dashboard" "example" {
    dashboard_id = random_uuid.dashboard_id.result
    name = "example"
    version_description = "example"
    definition {
        data_set_identifiers_declarations {
            ...
        }
        sheets {
            ...
        }
        parameter_declarations {
            string_parameter_declaration {
                parameter_value_type = "SINGLE_VALUED"
                name = "myParameter"
                default_values {
                    dynamic_value {
                        user_name_column {
                            data_set_identifier = "example"
                            column_name = "user_name"
                        }
                        default_value_column {
                            data_set_identifier = "example"
                            column_name = "default_value"
                        }
                    }
                    static_values = ["NULL"]
                }
                values_when_unset {
                    value_when_unset_option = "NULL"
                }
            }
        }
    }
}

Steps to Reproduce

terraform init
terraform plan
terraform apply

Debug Output

No response

Panic Output

No response

Important Factoids

I think that columnSchema should be changed to accept a boolean argument required, similarly to other schemas:

terraform-provider-aws/internal/service/quicksight/schema/template.go

Line 224 in b41e8d7

func columnSchema() *schema.Schema {

Then change columnSchema() to columnSchema(false) on this line:

terraform-provider-aws/internal/service/quicksight/schema/template_parameter.go

Line 258 in b41e8d7

"group_name_column": columnSchema(), // https://docs.aws.amazon.com/quicksight/latest/APIReference/API_ColumnIdentifier.html

and this line:

terraform-provider-aws/internal/service/quicksight/schema/template_parameter.go

Line 259 in b41e8d7

"user_name_column": columnSchema(), // https://docs.aws.amazon.com/quicksight/latest/APIReference/API_ColumnIdentifier.html

and then change all other instances of columnSchema() to columnSchema(true)

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DynamicDefaultValue.html

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.