Fix aws_iam_instance_profile detects that the instance profile is not associated with IAM Role.

[kuredev]

Description

Changed to detect when aws_iam_instance_profile is deleted in the aws environment.

Before/After

example main.tf

required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "~> 5.0"
    }
  }
}

provider "aws" {
  region = "ap-northeast-1"
}

resource "aws_iam_role" "sample_role" {
  name = "sample_role_20231024"
  assume_role_policy = <<EOF
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Action": "sts:AssumeRole",
      "Principal": {
        "Service": "ec2.amazonaws.com"
      },
      "Effect": "Allow",
      "Sid": ""
    }
  ]
}
EOF
}

resource "aws_iam_instance_profile" "sample_profile" {
  name  = "sample_profile_20231024"
  role = aws_iam_role.sample_role.name
}

Before

terraform apply
aws iam remove-role-from-instance-profile --instance-profile-name "sample_profile_20231024" --role-name "sample_role_20231024"
terraform apply # => "No changes"

After

terraform apply
aws iam remove-role-from-instance-profile --instance-profile-name "sample_profile_20231024" --role-name "sample_role_20231024"
terraform apply

Output

  ~ resource "aws_iam_instance_profile" "sample_profile" {
        id          = "sample_profile_20231024"
        name        = "sample_profile_20231024"
      + role        = "sample_role_20231024"
        tags        = {}
        # (5 unchanged attributes hidden)
    }

Relations

Closes #32671
Closes #24974
Closes #25646
Closes #24540
Closes #1680

References

Output from Acceptance Testing

 % make testacc TESTS='TestAccIAMInstanceProfile_*' PKG=iam                                  (git)-[b-fix-iam-instance-profile-role-nil] 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMInstanceProfile_*'  -timeout 360m
=== RUN   TestAccIAMInstanceProfileDataSource_basic
=== PAUSE TestAccIAMInstanceProfileDataSource_basic
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMInstanceProfile_withoutRole
=== PAUSE TestAccIAMInstanceProfile_withoutRole
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_nameGenerated
=== PAUSE TestAccIAMInstanceProfile_nameGenerated
=== RUN   TestAccIAMInstanceProfile_namePrefix
=== PAUSE TestAccIAMInstanceProfile_namePrefix
=== RUN   TestAccIAMInstanceProfile_disappears
=== PAUSE TestAccIAMInstanceProfile_disappears
=== RUN   TestAccIAMInstanceProfile_Disappears_role
=== PAUSE TestAccIAMInstanceProfile_Disappears_role
=== RUN   TestAccIAMInstanceProfilesDataSource_basic
=== PAUSE TestAccIAMInstanceProfilesDataSource_basic
=== CONT  TestAccIAMInstanceProfileDataSource_basic
=== CONT  TestAccIAMInstanceProfile_namePrefix
=== CONT  TestAccIAMInstanceProfilesDataSource_basic
=== CONT  TestAccIAMInstanceProfile_Disappears_role
=== CONT  TestAccIAMInstanceProfile_disappears
=== CONT  TestAccIAMInstanceProfile_tags
=== CONT  TestAccIAMInstanceProfile_nameGenerated
=== CONT  TestAccIAMInstanceProfile_withoutRole
=== CONT  TestAccIAMInstanceProfile_basic
--- PASS: TestAccIAMInstanceProfileDataSource_basic (173.54s)
--- PASS: TestAccIAMInstanceProfilesDataSource_basic (173.63s)
--- PASS: TestAccIAMInstanceProfile_Disappears_role (173.70s)
--- PASS: TestAccIAMInstanceProfile_withoutRole (173.72s)
--- PASS: TestAccIAMInstanceProfile_disappears (175.87s)
--- PASS: TestAccIAMInstanceProfile_namePrefix (185.64s)
--- PASS: TestAccIAMInstanceProfile_basic (185.69s)
--- PASS: TestAccIAMInstanceProfile_nameGenerated (185.84s)
--- PASS: TestAccIAMInstanceProfile_tags (227.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iam        227.872s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[YakDriver]

LGTM 🎉

% make t T=TestAccIAMInstanceProfile_ K=iam P=8
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/iam/... -v -count 1 -parallel 8 -run='TestAccIAMInstanceProfile_'  -timeout 360m
=== RUN   TestAccIAMInstanceProfile_tags
=== PAUSE TestAccIAMInstanceProfile_tags
=== RUN   TestAccIAMInstanceProfile_tags_null
=== PAUSE TestAccIAMInstanceProfile_tags_null
=== RUN   TestAccIAMInstanceProfile_tags_AddOnUpdate
=== PAUSE TestAccIAMInstanceProfile_tags_AddOnUpdate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccIAMInstanceProfile_basic
=== PAUSE TestAccIAMInstanceProfile_basic
=== RUN   TestAccIAMInstanceProfile_withoutRole
=== PAUSE TestAccIAMInstanceProfile_withoutRole
=== RUN   TestAccIAMInstanceProfile_nameGenerated
=== PAUSE TestAccIAMInstanceProfile_nameGenerated
=== RUN   TestAccIAMInstanceProfile_namePrefix
=== PAUSE TestAccIAMInstanceProfile_namePrefix
=== RUN   TestAccIAMInstanceProfile_disappears
=== PAUSE TestAccIAMInstanceProfile_disappears
=== RUN   TestAccIAMInstanceProfile_Disappears_role
=== PAUSE TestAccIAMInstanceProfile_Disappears_role
=== RUN   TestAccIAMInstanceProfile_launchConfiguration
=== PAUSE TestAccIAMInstanceProfile_launchConfiguration
=== CONT  TestAccIAMInstanceProfile_tags
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag
=== CONT  TestAccIAMInstanceProfile_nameGenerated
=== CONT  TestAccIAMInstanceProfile_basic
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag (21.78s)
=== CONT  TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate
--- PASS: TestAccIAMInstanceProfile_nameGenerated (24.82s)
=== CONT  TestAccIAMInstanceProfile_tags_AddOnUpdate
--- PASS: TestAccIAMInstanceProfile_basic (25.00s)
=== CONT  TestAccIAMInstanceProfile_tags_null
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly (37.96s)
=== CONT  TestAccIAMInstanceProfile_withoutRole
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace (40.32s)
=== CONT  TestAccIAMInstanceProfile_Disappears_role
--- PASS: TestAccIAMInstanceProfile_tags_null (33.35s)
=== CONT  TestAccIAMInstanceProfile_launchConfiguration
--- PASS: TestAccIAMInstanceProfile_Disappears_role (20.96s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add (61.32s)
=== CONT  TestAccIAMInstanceProfile_disappears
--- PASS: TestAccIAMInstanceProfile_withoutRole (24.00s)
=== CONT  TestAccIAMInstanceProfile_namePrefix
--- PASS: TestAccIAMInstanceProfile_tags_AddOnUpdate (41.36s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate (45.85s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_overlapping
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly (77.87s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccIAMInstanceProfile_disappears (21.43s)
=== CONT  TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag (22.49s)
--- PASS: TestAccIAMInstanceProfile_tags (86.27s)
--- PASS: TestAccIAMInstanceProfile_namePrefix (24.63s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag (21.64s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly (29.87s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_overlapping (47.52s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping (41.24s)
--- PASS: TestAccIAMInstanceProfile_launchConfiguration (79.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	140.397s

[github-actions]

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.