Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add Multi-Session support to AppStream Fleets #34245

Closed
ghost opened this issue Nov 3, 2023 · 6 comments · Fixed by #34266
Closed

[Enhancement]: Add Multi-Session support to AppStream Fleets #34245

ghost opened this issue Nov 3, 2023 · 6 comments · Fixed by #34266
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appstream Issues and PRs that pertain to the appstream service.
Milestone

Comments

@ghost
Copy link

ghost commented Nov 3, 2023

Description

AWS recently announced that it has added Multi-session capability to AppStream 2.0 fleets. See References for a link to the blog post.

It would be great to update the aws_appstream_fleet resource to take advantage of this new feature.

The AWS CLI options that handle this are --max-sessions-per-instance and --compute-capacity, as far as I can see.

Affected Resource(s) and/or Data Source(s)

  • aws_appstream_fleet

Potential Terraform Configuration

resource "aws_appstream_fleet" "test_fleet" {
  name = "test-fleet"

  compute_capacity {
    #desired_instances = 1     # existing option for a Single-Session Fleet
    desired_sessions = 1       # New option for a Mutli-Session Fleet (integer)
  }

  <snip>
  max_sessions_per_instance = 5   # New option for a Multi-Session Fleet (integer)
}

References

AWS Blog Post about multi-session Fleets: https://aws.amazon.com/about-aws/whats-new/2023/10/amazon-appstream-2-0-session-fleets-windows-server-os/
AWS CLI Reference link to "create-fleet": https://awscli.amazonaws.com/v2/documentation/api/latest/reference/appstream/create-fleet.html

Would you like to implement a fix?

No

@ghost ghost added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appstream Issues and PRs that pertain to the appstream service. label Nov 3, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 3, 2023
@DanielRieske
Copy link
Contributor

@ElliotPage-EI Thanks for raising this issue, I'll gladly pick it up and will add the PR shortly.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 7, 2023
@iamperson347
Copy link

We are interested in this as well. It looks like @DanielRieske kindly took this and made a PR for it, but it seems to have stagnated.

Copy link

github-actions bot commented Apr 2, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.44.0 milestone Apr 2, 2024
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented May 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appstream Issues and PRs that pertain to the appstream service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants