Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Policy document on aws_verifiedaccess_endpoint #34246

Closed
pmiranda07 opened this issue Nov 3, 2023 · 4 comments · Fixed by #34264
Closed

[Enhancement]: Policy document on aws_verifiedaccess_endpoint #34246

pmiranda07 opened this issue Nov 3, 2023 · 4 comments · Fixed by #34264
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service.
Milestone

Comments

@pmiranda07
Copy link

Description

The new resource aws_verifiedaccess_endpoint doesn't have a policy_document argument so that it is possible to upload a policy to the endpoint resource.
On the resource aws_verifiedaccess_group this argument is available, so the same argument should be available on the endpoint.
Thanks

Affected Resource(s) and/or Data Source(s)

aws_verifiedaccess_endpoint

Potential Terraform Configuration

resource "aws_verifiedaccess_endpoint" "example" {
  application_domain     = "example.com"
  attachment_type        = "vpc"
  description            = "example"
  domain_certificate_arn = aws_acm_certificate.example.arn
  endpoint_domain_prefix = "example"
  endpoint_type          = "load-balancer"
  load_balancer_options {
    load_balancer_arn = aws_lb.example.arn
    port              = 443
    protocol          = "https"
    subnet_ids        = [for subnet in aws_subnet.public : subnet.id]
  }
  security_group_ids       = [aws_security_group.example.id]
  verified_access_group_id = aws_verifiedaccess_group.example.id
  policy_document          = <<-EOT
            permit(principal, action, resource) 
                  when {
                  context.http_request.hostname == "example.com"
                };
        EOT 
}

References

No response

Would you like to implement a fix?

No

@pmiranda07 pmiranda07 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 3, 2023
@github-actions github-actions bot added the service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. label Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 3, 2023
@DanielRieske
Copy link
Contributor

@pmiranda07 Thanks for raising this issue, I'll gladly pick it up and will add the PR shortly.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 7, 2023
@github-actions github-actions bot added this to the v5.32.0 milestone Dec 22, 2023
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants