-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing workspace_id from importing aws_grafana_license_association #35290
fix: Add missing workspace_id from importing aws_grafana_license_association #35290
Conversation
Community NoteVoting for Prioritization
For Submitters
|
f3dfb4a
to
0391fdc
Compare
0391fdc
to
aa799b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial' PKG=grafana
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/grafana/... -v -count 1 -parallel 20 -run=TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial -timeout 360m
=== RUN TestAccGrafana_serial
=== PAUSE TestAccGrafana_serial
=== CONT TestAccGrafana_serial
=== RUN TestAccGrafana_serial/LicenseAssociation
=== RUN TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial
--- PASS: TestAccGrafana_serial (821.04s)
--- PASS: TestAccGrafana_serial/LicenseAssociation (821.04s)
--- PASS: TestAccGrafana_serial/LicenseAssociation/enterpriseFreeTrial (821.04s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/grafana 831.829s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the missing
workspace_id
attribute (which is the same asid
) to importedaws_grafana_license_association
resources.Relations
Closes #34714
References
n/a
Output from Acceptance Testing
While I have updated the test case
testAccLicenseAssociation_freeTrial
to also test import, I am not able to run it successfully because the underlying AWS API is throwing an error with looking up the marketplace agreement. I am able to reproduce the problem using just AWS CLI.Either way, here is the output: