Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_lb_listener_certificate documentation example correction #3602

Closed
oarmstrong opened this issue Mar 2, 2018 · 1 comment · Fixed by #3615
Closed

r/aws_lb_listener_certificate documentation example correction #3602

oarmstrong opened this issue Mar 2, 2018 · 1 comment · Fixed by #3615
Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service.

Comments

@oarmstrong
Copy link
Contributor

oarmstrong commented Mar 2, 2018

I wrote the documentation for the aws_lb_listener_certificate resource, and I've noticed there's a bug with the example resources.

resource "aws_lb_listener_certificate" "example" {
  listener_arn    = "${aws_lb_listener.front_end.arn}"
  certificate_arn  = "${aws_acm_certificate.example.arn}"
}

should be:

resource "aws_lb_listener_certificate" "example" {
  listener_arn    = "${aws_lb_listener.front_end.arn}"
  certificate_arn  = "${data.aws_acm_certificate.example.arn}"
}

Despite that, with #2813 we should probably be using the aws_acm_certificate resource instead of the datasource in that example anyway.

I'm happy to get to this myself later on today.

@oarmstrong oarmstrong changed the title r/aws_lb_listener_certificate documentation r/aws_lb_listener_certificate documentation example correction Mar 2, 2018
@bflad bflad added documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Mar 2, 2018
@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants