-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing type-specific args for aws_datasync_location_* resources #36072
fix: Add missing type-specific args for aws_datasync_location_* resources #36072
Conversation
Community NoteVoting for Prioritization
For Submitters
|
5363e66
to
6f1b69a
Compare
6f1b69a
to
7acb5a5
Compare
7acb5a5
to
b31eb81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDataSyncLocationAzureBlob_\|TestAccDataSyncLocationEFS_\|TestAccDataSyncLocationNFS_\|TestAccDataSyncLocationS3_\|TestAccDataSyncLocationSMB_' PKG=datasync ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/datasync/... -v -count 1 -parallel 3 -run=TestAccDataSyncLocationAzureBlob_\|TestAccDataSyncLocationEFS_\|TestAccDataSyncLocationNFS_\|TestAccDataSyncLocationS3_\|TestAccDataSyncLocationSMB_ -timeout 360m
=== RUN TestAccDataSyncLocationAzureBlob_basic
=== PAUSE TestAccDataSyncLocationAzureBlob_basic
=== RUN TestAccDataSyncLocationAzureBlob_disappears
=== PAUSE TestAccDataSyncLocationAzureBlob_disappears
=== RUN TestAccDataSyncLocationAzureBlob_tags
=== PAUSE TestAccDataSyncLocationAzureBlob_tags
=== RUN TestAccDataSyncLocationAzureBlob_update
=== PAUSE TestAccDataSyncLocationAzureBlob_update
=== RUN TestAccDataSyncLocationEFS_basic
=== PAUSE TestAccDataSyncLocationEFS_basic
=== RUN TestAccDataSyncLocationEFS_accessPointARN
=== PAUSE TestAccDataSyncLocationEFS_accessPointARN
=== RUN TestAccDataSyncLocationEFS_disappears
=== PAUSE TestAccDataSyncLocationEFS_disappears
=== RUN TestAccDataSyncLocationEFS_subdirectory
=== PAUSE TestAccDataSyncLocationEFS_subdirectory
=== RUN TestAccDataSyncLocationEFS_tags
=== PAUSE TestAccDataSyncLocationEFS_tags
=== RUN TestAccDataSyncLocationNFS_basic
=== PAUSE TestAccDataSyncLocationNFS_basic
=== RUN TestAccDataSyncLocationNFS_mountOptions
=== PAUSE TestAccDataSyncLocationNFS_mountOptions
=== RUN TestAccDataSyncLocationNFS_disappears
=== PAUSE TestAccDataSyncLocationNFS_disappears
=== RUN TestAccDataSyncLocationNFS_AgentARNs_multiple
=== PAUSE TestAccDataSyncLocationNFS_AgentARNs_multiple
=== RUN TestAccDataSyncLocationNFS_subdirectory
=== PAUSE TestAccDataSyncLocationNFS_subdirectory
=== RUN TestAccDataSyncLocationNFS_tags
=== PAUSE TestAccDataSyncLocationNFS_tags
=== RUN TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== RUN TestAccDataSyncLocationSMB_basic
=== PAUSE TestAccDataSyncLocationSMB_basic
=== RUN TestAccDataSyncLocationSMB_disappears
=== PAUSE TestAccDataSyncLocationSMB_disappears
=== RUN TestAccDataSyncLocationSMB_tags
=== PAUSE TestAccDataSyncLocationSMB_tags
=== CONT TestAccDataSyncLocationAzureBlob_basic
=== CONT TestAccDataSyncLocationNFS_disappears
=== CONT TestAccDataSyncLocationS3_disappears
--- PASS: TestAccDataSyncLocationS3_disappears (32.88s)
=== CONT TestAccDataSyncLocationSMB_disappears
--- PASS: TestAccDataSyncLocationNFS_disappears (156.51s)
=== CONT TestAccDataSyncLocationSMB_tags
--- PASS: TestAccDataSyncLocationAzureBlob_basic (186.30s)
=== CONT TestAccDataSyncLocationNFS_tags
--- PASS: TestAccDataSyncLocationSMB_disappears (154.74s)
=== CONT TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_storageClass (32.41s)
=== CONT TestAccDataSyncLocationS3_basic
--- PASS: TestAccDataSyncLocationS3_basic (34.04s)
=== CONT TestAccDataSyncLocationSMB_basic
--- PASS: TestAccDataSyncLocationSMB_tags (149.71s)
=== CONT TestAccDataSyncLocationNFS_subdirectory
--- PASS: TestAccDataSyncLocationNFS_tags (200.53s)
=== CONT TestAccDataSyncLocationNFS_AgentARNs_multiple
--- PASS: TestAccDataSyncLocationSMB_basic (136.97s)
=== CONT TestAccDataSyncLocationEFS_disappears
--- PASS: TestAccDataSyncLocationNFS_subdirectory (164.84s)
=== CONT TestAccDataSyncLocationNFS_mountOptions
--- PASS: TestAccDataSyncLocationEFS_disappears (134.92s)
=== CONT TestAccDataSyncLocationNFS_basic
--- PASS: TestAccDataSyncLocationNFS_AgentARNs_multiple (178.82s)
=== CONT TestAccDataSyncLocationEFS_tags
--- PASS: TestAccDataSyncLocationNFS_mountOptions (137.91s)
=== CONT TestAccDataSyncLocationEFS_subdirectory
--- PASS: TestAccDataSyncLocationNFS_basic (133.12s)
=== CONT TestAccDataSyncLocationAzureBlob_update
--- PASS: TestAccDataSyncLocationEFS_tags (169.70s)
=== CONT TestAccDataSyncLocationEFS_accessPointARN
--- PASS: TestAccDataSyncLocationEFS_subdirectory (136.17s)
=== CONT TestAccDataSyncLocationEFS_basic
--- PASS: TestAccDataSyncLocationAzureBlob_update (158.80s)
=== CONT TestAccDataSyncLocationAzureBlob_tags
--- PASS: TestAccDataSyncLocationEFS_basic (127.41s)
=== CONT TestAccDataSyncLocationAzureBlob_disappears
--- PASS: TestAccDataSyncLocationEFS_accessPointARN (137.49s)
=== CONT TestAccDataSyncLocationS3_tags
--- PASS: TestAccDataSyncLocationS3_tags (68.78s)
--- PASS: TestAccDataSyncLocationAzureBlob_tags (166.70s)
--- PASS: TestAccDataSyncLocationAzureBlob_disappears (162.38s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 1042.679s
% make testacc TESTARGS='-run=TestAccAutoScalingLaunchConfiguration_userData' PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run=TestAccAutoScalingLaunchConfiguration_userData -timeout 360m
=== RUN TestAccAutoScalingLaunchConfiguration_userData
=== PAUSE TestAccAutoScalingLaunchConfiguration_userData
=== CONT TestAccAutoScalingLaunchConfiguration_userData
--- PASS: TestAccAutoScalingLaunchConfiguration_userData (73.02s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 79.708s
% make testacc TESTARGS='-run=TestAccEC2Instance_userData' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2Instance_userData -timeout 360m
=== RUN TestAccEC2Instance_userDataBase64
=== PAUSE TestAccEC2Instance_userDataBase64
=== RUN TestAccEC2Instance_userDataBase64_updateWithBashFile
=== PAUSE TestAccEC2Instance_userDataBase64_updateWithBashFile
=== RUN TestAccEC2Instance_userDataBase64_updateWithZipFile
=== PAUSE TestAccEC2Instance_userDataBase64_updateWithZipFile
=== RUN TestAccEC2Instance_userDataBase64_update
=== PAUSE TestAccEC2Instance_userDataBase64_update
=== CONT TestAccEC2Instance_userDataBase64
=== CONT TestAccEC2Instance_userDataBase64_updateWithZipFile
=== CONT TestAccEC2Instance_userDataBase64_updateWithBashFile
=== CONT TestAccEC2Instance_userDataBase64_update
--- PASS: TestAccEC2Instance_userDataBase64 (121.54s)
--- PASS: TestAccEC2Instance_userDataBase64_updateWithBashFile (226.80s)
--- PASS: TestAccEC2Instance_userDataBase64_update (246.62s)
--- PASS: TestAccEC2Instance_userDataBase64_updateWithZipFile (269.38s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 276.087s
% make testacc TESTARGS='-run=TestAccIAMAccessKey_' PKG=iam ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/iam/... -v -count 1 -parallel 3 -run=TestAccIAMAccessKey_ -timeout 360m
=== RUN TestAccIAMAccessKey_basic
=== PAUSE TestAccIAMAccessKey_basic
=== RUN TestAccIAMAccessKey_disappears
=== PAUSE TestAccIAMAccessKey_disappears
=== RUN TestAccIAMAccessKey_encrypted
=== PAUSE TestAccIAMAccessKey_encrypted
=== RUN TestAccIAMAccessKey_status
=== PAUSE TestAccIAMAccessKey_status
=== CONT TestAccIAMAccessKey_basic
=== CONT TestAccIAMAccessKey_encrypted
=== CONT TestAccIAMAccessKey_disappears
--- PASS: TestAccIAMAccessKey_disappears (21.36s)
=== CONT TestAccIAMAccessKey_status
--- PASS: TestAccIAMAccessKey_basic (25.18s)
--- PASS: TestAccIAMAccessKey_encrypted (25.20s)
--- PASS: TestAccIAMAccessKey_status (42.20s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 70.539s
% make testacc TESTARGS='-run=TestAccImageBuilderImageRecipe_userDataBase64' PKG=imagebuilder ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/imagebuilder/... -v -count 1 -parallel 3 -run=TestAccImageBuilderImageRecipe_userDataBase64 -timeout 360m
=== RUN TestAccImageBuilderImageRecipe_userDataBase64
=== PAUSE TestAccImageBuilderImageRecipe_userDataBase64
=== CONT TestAccImageBuilderImageRecipe_userDataBase64
--- PASS: TestAccImageBuilderImageRecipe_userDataBase64 (24.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder 31.236s
% make testacc TESTARGS='-run=TestAccKMSCiphertext_\|TestAccKMSCiphertextDataSource_\|TestAccKMSExternalKey_\|TestAccKMSPublicKeyDataSource_\|TestAccKMSSecretsDataSource_' PKG=kms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/kms/... -v -count 1 -parallel 3 -run=TestAccKMSCiphertext_\|TestAccKMSCiphertextDataSource_\|TestAccKMSExternalKey_\|TestAccKMSPublicKeyDataSource_\|TestAccKMSSecretsDataSource_ -timeout 360m
=== RUN TestAccKMSCiphertextDataSource_basic
=== PAUSE TestAccKMSCiphertextDataSource_basic
=== RUN TestAccKMSCiphertextDataSource_validate
=== PAUSE TestAccKMSCiphertextDataSource_validate
=== RUN TestAccKMSCiphertextDataSource_Validate_withContext
=== PAUSE TestAccKMSCiphertextDataSource_Validate_withContext
=== RUN TestAccKMSCiphertext_Resource_basic
=== PAUSE TestAccKMSCiphertext_Resource_basic
=== RUN TestAccKMSCiphertext_Resource_validate
=== PAUSE TestAccKMSCiphertext_Resource_validate
=== RUN TestAccKMSCiphertext_ResourceValidate_withContext
=== PAUSE TestAccKMSCiphertext_ResourceValidate_withContext
=== RUN TestAccKMSExternalKey_basic
=== PAUSE TestAccKMSExternalKey_basic
=== RUN TestAccKMSExternalKey_disappears
=== PAUSE TestAccKMSExternalKey_disappears
=== RUN TestAccKMSExternalKey_multiRegion
=== PAUSE TestAccKMSExternalKey_multiRegion
=== RUN TestAccKMSExternalKey_deletionWindowInDays
=== PAUSE TestAccKMSExternalKey_deletionWindowInDays
=== RUN TestAccKMSExternalKey_description
=== PAUSE TestAccKMSExternalKey_description
=== RUN TestAccKMSExternalKey_enabled
=== PAUSE TestAccKMSExternalKey_enabled
=== RUN TestAccKMSExternalKey_keyMaterialBase64
=== PAUSE TestAccKMSExternalKey_keyMaterialBase64
=== RUN TestAccKMSExternalKey_policy
=== PAUSE TestAccKMSExternalKey_policy
=== RUN TestAccKMSExternalKey_policyBypass
=== PAUSE TestAccKMSExternalKey_policyBypass
=== RUN TestAccKMSExternalKey_tags
=== PAUSE TestAccKMSExternalKey_tags
=== RUN TestAccKMSExternalKey_validTo
=== PAUSE TestAccKMSExternalKey_validTo
=== RUN TestAccKMSPublicKeyDataSource_basic
=== PAUSE TestAccKMSPublicKeyDataSource_basic
=== RUN TestAccKMSPublicKeyDataSource_encrypt
=== PAUSE TestAccKMSPublicKeyDataSource_encrypt
=== RUN TestAccKMSSecretsDataSource_basic
=== PAUSE TestAccKMSSecretsDataSource_basic
=== RUN TestAccKMSSecretsDataSource_asymmetric
=== PAUSE TestAccKMSSecretsDataSource_asymmetric
=== CONT TestAccKMSCiphertextDataSource_basic
=== CONT TestAccKMSExternalKey_enabled
=== CONT TestAccKMSExternalKey_basic
--- PASS: TestAccKMSCiphertextDataSource_basic (21.77s)
=== CONT TestAccKMSExternalKey_description
--- PASS: TestAccKMSExternalKey_basic (25.54s)
=== CONT TestAccKMSExternalKey_deletionWindowInDays
--- PASS: TestAccKMSExternalKey_deletionWindowInDays (36.62s)
=== CONT TestAccKMSExternalKey_multiRegion
--- PASS: TestAccKMSExternalKey_description (44.88s)
=== CONT TestAccKMSExternalKey_disappears
--- PASS: TestAccKMSExternalKey_multiRegion (23.32s)
=== CONT TestAccKMSCiphertext_Resource_basic
--- PASS: TestAccKMSExternalKey_disappears (19.81s)
=== CONT TestAccKMSCiphertext_ResourceValidate_withContext
--- PASS: TestAccKMSCiphertext_Resource_basic (17.56s)
=== CONT TestAccKMSCiphertext_Resource_validate
--- PASS: TestAccKMSCiphertext_ResourceValidate_withContext (18.15s)
=== CONT TestAccKMSCiphertextDataSource_Validate_withContext
--- PASS: TestAccKMSCiphertext_Resource_validate (17.15s)
=== CONT TestAccKMSExternalKey_validTo
--- PASS: TestAccKMSCiphertextDataSource_Validate_withContext (16.68s)
=== CONT TestAccKMSSecretsDataSource_asymmetric
--- PASS: TestAccKMSExternalKey_enabled (149.10s)
=== CONT TestAccKMSSecretsDataSource_basic
--- PASS: TestAccKMSSecretsDataSource_asymmetric (32.43s)
=== CONT TestAccKMSPublicKeyDataSource_encrypt
--- PASS: TestAccKMSPublicKeyDataSource_encrypt (17.61s)
=== CONT TestAccKMSPublicKeyDataSource_basic
--- PASS: TestAccKMSSecretsDataSource_basic (39.35s)
=== CONT TestAccKMSExternalKey_policyBypass
--- PASS: TestAccKMSPublicKeyDataSource_basic (22.24s)
=== CONT TestAccKMSExternalKey_tags
--- PASS: TestAccKMSExternalKey_policyBypass (26.34s)
=== CONT TestAccKMSCiphertextDataSource_validate
--- PASS: TestAccKMSCiphertextDataSource_validate (21.07s)
=== CONT TestAccKMSExternalKey_policy
--- PASS: TestAccKMSExternalKey_tags (87.56s)
=== CONT TestAccKMSExternalKey_keyMaterialBase64
--- PASS: TestAccKMSExternalKey_policy (45.43s)
--- PASS: TestAccKMSExternalKey_validTo (164.09s)
--- PASS: TestAccKMSExternalKey_keyMaterialBase64 (108.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kms 396.807s
% make testacc TESTARGS='-run=TestAccSecretsManagerSecretVersion_base64Binary' PKG=secretsmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/secretsmanager/... -v -count 1 -parallel 3 -run=TestAccSecretsManagerSecretVersion_base64Binary -timeout 360m
=== RUN TestAccSecretsManagerSecretVersion_base64Binary
=== PAUSE TestAccSecretsManagerSecretVersion_base64Binary
=== CONT TestAccSecretsManagerSecretVersion_base64Binary
--- PASS: TestAccSecretsManagerSecretVersion_base64Binary (21.17s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 28.254s
% make testacc TESTARGS='-run=TestAccS3Object_' PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/s3/... -v -count 1 -parallel 3 -run=TestAccS3Object_ -timeout 360m
=== RUN TestAccS3Object_basic
=== PAUSE TestAccS3Object_basic
=== RUN TestAccS3Object_disappears
=== PAUSE TestAccS3Object_disappears
=== RUN TestAccS3Object_Disappears_bucket
=== PAUSE TestAccS3Object_Disappears_bucket
=== RUN TestAccS3Object_source
=== PAUSE TestAccS3Object_source
=== RUN TestAccS3Object_content
=== PAUSE TestAccS3Object_content
=== RUN TestAccS3Object_etagEncryption
=== PAUSE TestAccS3Object_etagEncryption
=== RUN TestAccS3Object_contentBase64
=== PAUSE TestAccS3Object_contentBase64
=== RUN TestAccS3Object_sourceHashTrigger
=== PAUSE TestAccS3Object_sourceHashTrigger
=== RUN TestAccS3Object_withContentCharacteristics
=== PAUSE TestAccS3Object_withContentCharacteristics
=== RUN TestAccS3Object_nonVersioned
=== PAUSE TestAccS3Object_nonVersioned
=== RUN TestAccS3Object_updates
=== PAUSE TestAccS3Object_updates
=== RUN TestAccS3Object_updateSameFile
=== PAUSE TestAccS3Object_updateSameFile
=== RUN TestAccS3Object_updatesWithVersioning
=== PAUSE TestAccS3Object_updatesWithVersioning
=== RUN TestAccS3Object_updatesWithVersioningViaAccessPoint
=== PAUSE TestAccS3Object_updatesWithVersioningViaAccessPoint
=== RUN TestAccS3Object_kms
=== PAUSE TestAccS3Object_kms
=== RUN TestAccS3Object_sse
=== PAUSE TestAccS3Object_sse
=== RUN TestAccS3Object_acl
=== PAUSE TestAccS3Object_acl
=== RUN TestAccS3Object_metadata
=== PAUSE TestAccS3Object_metadata
=== RUN TestAccS3Object_storageClass
=== PAUSE TestAccS3Object_storageClass
=== RUN TestAccS3Object_tags
=== PAUSE TestAccS3Object_tags
=== RUN TestAccS3Object_tagsLeadingSingleSlash
=== PAUSE TestAccS3Object_tagsLeadingSingleSlash
=== RUN TestAccS3Object_tagsLeadingMultipleSlashes
=== PAUSE TestAccS3Object_tagsLeadingMultipleSlashes
=== RUN TestAccS3Object_tagsMultipleSlashes
=== PAUSE TestAccS3Object_tagsMultipleSlashes
=== RUN TestAccS3Object_tags_EmptyTag_OnCreate
=== PAUSE TestAccS3Object_tags_EmptyTag_OnCreate
=== RUN TestAccS3Object_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccS3Object_tags_EmptyTag_OnUpdate_Add
=== RUN TestAccS3Object_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccS3Object_tags_EmptyTag_OnUpdate_Replace
=== RUN TestAccS3Object_DefaultTags_providerOnly
=== PAUSE TestAccS3Object_DefaultTags_providerOnly
=== RUN TestAccS3Object_DefaultTags_providerAndResource
=== PAUSE TestAccS3Object_DefaultTags_providerAndResource
=== RUN TestAccS3Object_DefaultTags_providerAndResourceWithOverride
=== PAUSE TestAccS3Object_DefaultTags_providerAndResourceWithOverride
=== RUN TestAccS3Object_tagsViaAccessPointARN
=== PAUSE TestAccS3Object_tagsViaAccessPointARN
=== RUN TestAccS3Object_tagsViaAccessPointAlias
=== PAUSE TestAccS3Object_tagsViaAccessPointAlias
=== RUN TestAccS3Object_tagsViaMultiRegionAccessPoint
=== PAUSE TestAccS3Object_tagsViaMultiRegionAccessPoint
=== RUN TestAccS3Object_tagsViaObjectLambdaAccessPointARN
object_test.go:1540: Accessing Objects via Lambda Access Points is not yet supported
--- SKIP: TestAccS3Object_tagsViaObjectLambdaAccessPointARN (0.00s)
=== RUN TestAccS3Object_objectLockLegalHoldStartWithNone
=== PAUSE TestAccS3Object_objectLockLegalHoldStartWithNone
=== RUN TestAccS3Object_objectLockLegalHoldStartWithOn
=== PAUSE TestAccS3Object_objectLockLegalHoldStartWithOn
=== RUN TestAccS3Object_objectLockRetentionStartWithNone
=== PAUSE TestAccS3Object_objectLockRetentionStartWithNone
=== RUN TestAccS3Object_objectLockRetentionStartWithSet
=== PAUSE TestAccS3Object_objectLockRetentionStartWithSet
=== RUN TestAccS3Object_objectBucketKeyEnabled
=== PAUSE TestAccS3Object_objectBucketKeyEnabled
=== RUN TestAccS3Object_bucketBucketKeyEnabled
=== PAUSE TestAccS3Object_bucketBucketKeyEnabled
=== RUN TestAccS3Object_defaultBucketSSE
=== PAUSE TestAccS3Object_defaultBucketSSE
=== RUN TestAccS3Object_ignoreTags
=== PAUSE TestAccS3Object_ignoreTags
=== RUN TestAccS3Object_checksumAlgorithm
=== PAUSE TestAccS3Object_checksumAlgorithm
=== RUN TestAccS3Object_directoryBucket
=== PAUSE TestAccS3Object_directoryBucket
=== RUN TestAccS3Object_DirectoryBucket_disappears
=== PAUSE TestAccS3Object_DirectoryBucket_disappears
=== RUN TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly
=== PAUSE TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly
=== RUN TestAccS3Object_prefix
=== PAUSE TestAccS3Object_prefix
=== RUN TestAccS3Object_crossRegion
=== PAUSE TestAccS3Object_crossRegion
=== RUN TestAccS3Object_optInRegion
=== PAUSE TestAccS3Object_optInRegion
=== CONT TestAccS3Object_basic
=== CONT TestAccS3Object_tags_EmptyTag_OnUpdate_Add
=== CONT TestAccS3Object_updatesWithVersioning
--- PASS: TestAccS3Object_basic (27.12s)
=== CONT TestAccS3Object_tags_EmptyTag_OnCreate
--- PASS: TestAccS3Object_tags_EmptyTag_OnUpdate_Add (52.47s)
=== CONT TestAccS3Object_tagsMultipleSlashes
--- PASS: TestAccS3Object_updatesWithVersioning (52.60s)
=== CONT TestAccS3Object_tagsLeadingMultipleSlashes
--- PASS: TestAccS3Object_tags_EmptyTag_OnCreate (30.33s)
=== CONT TestAccS3Object_tagsLeadingSingleSlash
--- PASS: TestAccS3Object_tagsMultipleSlashes (86.39s)
=== CONT TestAccS3Object_tags
--- PASS: TestAccS3Object_tagsLeadingMultipleSlashes (86.29s)
=== CONT TestAccS3Object_storageClass
--- PASS: TestAccS3Object_tagsLeadingSingleSlash (87.72s)
=== CONT TestAccS3Object_metadata
--- PASS: TestAccS3Object_metadata (59.03s)
=== CONT TestAccS3Object_acl
--- PASS: TestAccS3Object_tags (88.61s)
=== CONT TestAccS3Object_sse
--- PASS: TestAccS3Object_storageClass (92.54s)
=== CONT TestAccS3Object_kms
--- PASS: TestAccS3Object_sse (26.92s)
=== CONT TestAccS3Object_updatesWithVersioningViaAccessPoint
--- PASS: TestAccS3Object_kms (27.35s)
=== CONT TestAccS3Object_contentBase64
--- PASS: TestAccS3Object_acl (72.87s)
=== CONT TestAccS3Object_nonVersioned
object_test.go:462: skipping test; environment variable TF_ACC_ASSUME_ROLE_ARN must be set. Usage: Amazon Resource Name (ARN) of existing IAM Role to assume for testing restricted permissions
--- SKIP: TestAccS3Object_nonVersioned (0.00s)
=== CONT TestAccS3Object_withContentCharacteristics
--- PASS: TestAccS3Object_contentBase64 (22.02s)
=== CONT TestAccS3Object_sourceHashTrigger
--- PASS: TestAccS3Object_withContentCharacteristics (21.68s)
=== CONT TestAccS3Object_objectBucketKeyEnabled
--- PASS: TestAccS3Object_updatesWithVersioningViaAccessPoint (50.30s)
=== CONT TestAccS3Object_updateSameFile
--- PASS: TestAccS3Object_objectBucketKeyEnabled (23.15s)
=== CONT TestAccS3Object_updates
--- PASS: TestAccS3Object_sourceHashTrigger (44.75s)
=== CONT TestAccS3Object_source
--- PASS: TestAccS3Object_source (27.22s)
=== CONT TestAccS3Object_optInRegion
--- PASS: TestAccS3Object_updateSameFile (48.18s)
=== CONT TestAccS3Object_etagEncryption
=== NAME TestAccS3Object_optInRegion
object_test.go:2170: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccS3Object_optInRegion (0.60s)
=== CONT TestAccS3Object_crossRegion
--- PASS: TestAccS3Object_crossRegion (15.68s)
=== CONT TestAccS3Object_prefix
--- PASS: TestAccS3Object_updates (52.92s)
=== CONT TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly
--- PASS: TestAccS3Object_etagEncryption (28.05s)
=== CONT TestAccS3Object_DirectoryBucket_disappears
=== CONT TestAccS3Object_directoryBucket
--- PASS: TestAccS3Object_prefix (26.46s)
--- PASS: TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly (21.00s)
=== CONT TestAccS3Object_content
--- PASS: TestAccS3Object_DirectoryBucket_disappears (23.98s)
=== CONT TestAccS3Object_checksumAlgorithm
--- PASS: TestAccS3Object_content (27.29s)
=== CONT TestAccS3Object_Disappears_bucket
--- PASS: TestAccS3Object_directoryBucket (28.64s)
=== CONT TestAccS3Object_ignoreTags
--- PASS: TestAccS3Object_Disappears_bucket (23.70s)
=== CONT TestAccS3Object_defaultBucketSSE
--- PASS: TestAccS3Object_checksumAlgorithm (45.50s)
=== CONT TestAccS3Object_DefaultTags_providerAndResource
--- PASS: TestAccS3Object_defaultBucketSSE (23.70s)
=== CONT TestAccS3Object_bucketBucketKeyEnabled
--- PASS: TestAccS3Object_ignoreTags (49.37s)
=== CONT TestAccS3Object_tagsViaAccessPointARN
--- PASS: TestAccS3Object_bucketBucketKeyEnabled (23.84s)
=== CONT TestAccS3Object_tagsViaAccessPointAlias
--- PASS: TestAccS3Object_DefaultTags_providerAndResource (44.16s)
=== CONT TestAccS3Object_disappears
--- PASS: TestAccS3Object_disappears (26.61s)
=== CONT TestAccS3Object_DefaultTags_providerOnly
--- PASS: TestAccS3Object_tagsViaAccessPointARN (52.54s)
=== CONT TestAccS3Object_DefaultTags_providerAndResourceWithOverride
--- PASS: TestAccS3Object_DefaultTags_providerOnly (28.98s)
=== CONT TestAccS3Object_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccS3Object_tagsViaAccessPointAlias (57.30s)
=== CONT TestAccS3Object_objectLockLegalHoldStartWithOn
--- PASS: TestAccS3Object_DefaultTags_providerAndResourceWithOverride (47.97s)
=== CONT TestAccS3Object_objectLockLegalHoldStartWithNone
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithOn (48.42s)
=== CONT TestAccS3Object_tagsViaMultiRegionAccessPoint
--- PASS: TestAccS3Object_tags_EmptyTag_OnUpdate_Replace (52.82s)
=== CONT TestAccS3Object_objectLockRetentionStartWithNone
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithNone (66.35s)
=== CONT TestAccS3Object_objectLockRetentionStartWithSet
--- PASS: TestAccS3Object_objectLockRetentionStartWithNone (61.84s)
--- PASS: TestAccS3Object_objectLockRetentionStartWithSet (79.54s)
--- PASS: TestAccS3Object_tagsViaMultiRegionAccessPoint (368.14s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 976.819s
% make testacc TESTARGS='-run=TestAccDataSyncLocationHDFS_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/datasync/... -v -count 1 -parallel 2 -run=TestAccDataSyncLocationHDFS_ -timeout 360m
=== RUN TestAccDataSyncLocationHDFS_basic
=== PAUSE TestAccDataSyncLocationHDFS_basic
=== RUN TestAccDataSyncLocationHDFS_disappears
=== PAUSE TestAccDataSyncLocationHDFS_disappears
=== RUN TestAccDataSyncLocationHDFS_tags
=== PAUSE TestAccDataSyncLocationHDFS_tags
=== RUN TestAccDataSyncLocationHDFS_kerberos
=== PAUSE TestAccDataSyncLocationHDFS_kerberos
=== CONT TestAccDataSyncLocationHDFS_basic
=== CONT TestAccDataSyncLocationHDFS_tags
--- PASS: TestAccDataSyncLocationHDFS_basic (115.80s)
=== CONT TestAccDataSyncLocationHDFS_kerberos
--- PASS: TestAccDataSyncLocationHDFS_tags (174.85s)
=== CONT TestAccDataSyncLocationHDFS_disappears
--- PASS: TestAccDataSyncLocationHDFS_kerberos (111.21s)
--- PASS: TestAccDataSyncLocationHDFS_disappears (117.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 299.088s
…tringValueToBase64String'.
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to add the missing type-specific attribute to the following
aws_datasync_location_
resources:aws_datasync_location_azure_blob
container_url
aws_datasync_location_efs
efs_file_system_arn
aws_datasync_location_nfs
server_hostname
aws_datasync_location_s3
s3_bucket_arn
aws_datasync_location_smb
server_hostname
For
aws_datasync_location_azure_blob
, it seems that the original handling ofsubdirectory
is also a bit off. The blob storage container URL should include the segment after the first/
since the root URL only accounts for the storage account. What follows the second/
would be the subdirectories i.e. the virtual directories. I have fixed thesubdirectory
attribute handling in this PR as well.Note: It seems that there are more resources in similar situations so I will go through them and attempt to deduce the type-specific attribute. The process is a bit wonky but it's probably better than fetching the actual resource for the information (expensive and adds to dependency/complexity).
Relations
Closes #33381.
Closes #33672.
Closes #31678.
References
Referred to LocationListEntry for the specs of location URI. Also reviewed DescribeLocationEfs and DescribeLocationNfs to determine whether the required fields are returned in the response (they aren't).
Output from Acceptance Testing
For
aws_datasync_location_azure_blob
:For
aws_datasync_location_efs
:For
aws_datasync_location_nfs
:For
aws_datasync_location_s3
:For
aws_datasync_location_smb
: