fix: Change event_destination.matching_event_types to Set to fix diff due to AWS-side sorting for aws_sesv2_configuration_set_event_destination #36897

acwwat · 2024-04-13T03:57:53Z

Description

This PR is to fix a perpetual diff issue with the aws_sesv2_configuration_set_event_destination resource due to AWS sorting the event_destination.matching_event_types list attr on the server side. If list is not order in the Terraform configuration, it will always generate a diff between the unsorted config and the sorted state. Although not ideal, the fix is to convert event_destination.matching_event_types to schema.TypeSet.

Aside from running the tests, I've also ensured compatibility by manually testing the type conversion location as follows:

With previous code, apply the test case that the reporter provided in [Bug]: resource "aws_sesv2_configuration_set_event_destination" always show changes #36896. I had to add the SNS topic resource to complete the config.
Apply multiple times to see the perpetual diff.
Make the code change and compile.
In local provider test mode, run apply to ensure that it now reports that no changes are detected.

Relations

Closes #36896

References

n/a

Output from Acceptance Testing

$ make testacc TESTS=TestAccSESV2ConfigurationSetEventDestination_ PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2ConfigurationSetEventDestination_'  -timeout 360m
=== RUN   TestAccSESV2ConfigurationSetEventDestination_basic
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_basic
=== RUN   TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_disappears
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_basic
=== CONT  TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_snsDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (78.32s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (123.24s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (123.52s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (163.12s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (163.12s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (328.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      328.542s

$

github-actions · 2024-04-13T03:58:05Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

… due to AWS-side sorting for aws_sesv2_configuration_set_event_destination

% make testacc TESTARGS='-run=TestAccSESV2ContactList_serial' PKG=sesv2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run=TestAccSESV2ContactList_serial -timeout 360m === RUN TestAccSESV2ContactList_serial === PAUSE TestAccSESV2ContactList_serial === CONT TestAccSESV2ContactList_serial === RUN TestAccSESV2ContactList_serial/basic === RUN TestAccSESV2ContactList_serial/disappears === RUN TestAccSESV2ContactList_serial/tags === RUN TestAccSESV2ContactList_serial/description === RUN TestAccSESV2ContactList_serial/topic --- PASS: TestAccSESV2ContactList_serial (86.14s) --- PASS: TestAccSESV2ContactList_serial/basic (13.70s) --- PASS: TestAccSESV2ContactList_serial/disappears (10.78s) --- PASS: TestAccSESV2ContactList_serial/tags (20.62s) --- PASS: TestAccSESV2ContactList_serial/description (20.42s) --- PASS: TestAccSESV2ContactList_serial/topic (20.61s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 91.211s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2ContactList_serial' PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2ContactList_serial -timeout 360m
=== RUN   TestAccSESV2ContactList_serial
=== PAUSE TestAccSESV2ContactList_serial
=== CONT  TestAccSESV2ContactList_serial
=== RUN   TestAccSESV2ContactList_serial/basic
=== RUN   TestAccSESV2ContactList_serial/disappears
=== RUN   TestAccSESV2ContactList_serial/tags
=== RUN   TestAccSESV2ContactList_serial/description
=== RUN   TestAccSESV2ContactList_serial/topic
--- PASS: TestAccSESV2ContactList_serial (86.14s)
    --- PASS: TestAccSESV2ContactList_serial/basic (13.70s)
    --- PASS: TestAccSESV2ContactList_serial/disappears (10.78s)
    --- PASS: TestAccSESV2ContactList_serial/tags (20.62s)
    --- PASS: TestAccSESV2ContactList_serial/description (20.42s)
    --- PASS: TestAccSESV2ContactList_serial/topic (20.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	91.211s

% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSet_\|TestAccSESV2ConfigurationSetDataSource_' PKG=sesv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 20  -run=TestAccSESV2ConfigurationSet_\|TestAccSESV2ConfigurationSetDataSource_ -timeout 360m
=== RUN   TestAccSESV2ConfigurationSetDataSource_basic
=== PAUSE TestAccSESV2ConfigurationSetDataSource_basic
=== RUN   TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN   TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN   TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN   TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== RUN   TestAccSESV2ConfigurationSet_engagementMetrics
=== PAUSE TestAccSESV2ConfigurationSet_engagementMetrics
=== RUN   TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== PAUSE TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== RUN   TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== CONT  TestAccSESV2ConfigurationSetDataSource_basic
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasons
=== CONT  TestAccSESV2ConfigurationSet_tlsPolicy
=== CONT  TestAccSESV2ConfigurationSet_optimizedSharedDelivery
=== CONT  TestAccSESV2ConfigurationSet_engagementMetrics
=== CONT  TestAccSESV2ConfigurationSet_sendingEnabled
=== CONT  TestAccSESV2ConfigurationSet_basic
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasonsEmpty
=== CONT  TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== CONT  TestAccSESV2ConfigurationSet_tags
=== CONT  TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_disappears (17.60s)
--- PASS: TestAccSESV2ConfigurationSetDataSource_basic (17.84s)
--- PASS: TestAccSESV2ConfigurationSet_basic (20.57s)
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasonsEmpty (24.25s)
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (27.89s)
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (31.37s)
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (31.46s)
--- PASS: TestAccSESV2ConfigurationSet_optimizedSharedDelivery (31.85s)
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (33.20s)
--- PASS: TestAccSESV2ConfigurationSet_tags (37.64s)
--- PASS: TestAccSESV2ConfigurationSet_engagementMetrics (39.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	44.741s

% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSetEventDestination_' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2ConfigurationSetEventDestination_ -timeout 360m
=== RUN   TestAccSESV2ConfigurationSetEventDestination_basic
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_basic
=== RUN   TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_disappears
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_basic
=== CONT  TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_disappears
--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (12.77s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_snsDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (22.48s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (24.43s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (23.67s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination (14.05s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (20.91s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (108.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	137.676s

% make testacc TESTARGS='-run=TestAccSESV2AccountVDMAttributes_serial' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2AccountVDMAttributes_serial -timeout 360m
=== RUN   TestAccSESV2AccountVDMAttributes_serial
=== PAUSE TestAccSESV2AccountVDMAttributes_serial
=== CONT  TestAccSESV2AccountVDMAttributes_serial
=== RUN   TestAccSESV2AccountVDMAttributes_serial/optimizedSharedDelivery
=== RUN   TestAccSESV2AccountVDMAttributes_serial/basic
=== RUN   TestAccSESV2AccountVDMAttributes_serial/disappears
=== RUN   TestAccSESV2AccountVDMAttributes_serial/engagementMetrics
--- PASS: TestAccSESV2AccountVDMAttributes_serial (63.37s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/optimizedSharedDelivery (20.74s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/basic (12.28s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/disappears (10.54s)
    --- PASS: TestAccSESV2AccountVDMAttributes_serial/engagementMetrics (19.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	68.462s

% make testacc TESTARGS='-run=TestAccSESV2DedicatedIPAssignment_serial' PKG=sesv2 ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2DedicatedIPAssignment_serial -timeout 360m
=== RUN   TestAccSESV2DedicatedIPAssignment_serial
=== PAUSE TestAccSESV2DedicatedIPAssignment_serial
=== CONT  TestAccSESV2DedicatedIPAssignment_serial
=== RUN   TestAccSESV2DedicatedIPAssignment_serial/basic
    dedicated_ip_assignment_test.go:36: Environment variable SES_DEDICATED_IP is not set
=== RUN   TestAccSESV2DedicatedIPAssignment_serial/disappears
    dedicated_ip_assignment_test.go:69: Environment variable SES_DEDICATED_IP is not set
--- PASS: TestAccSESV2DedicatedIPAssignment_serial (0.00s)
    --- SKIP: TestAccSESV2DedicatedIPAssignment_serial/basic (0.00s)
    --- SKIP: TestAccSESV2DedicatedIPAssignment_serial/disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	5.076s

% make testacc TESTARGS='-run=TestAccSESV2DedicatedIPPool_\|TestAccSESV2DedicatedIPPoolDataSource_' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2DedicatedIPPool_\|TestAccSESV2DedicatedIPPoolDataSource_ -timeout 360m
=== RUN   TestAccSESV2DedicatedIPPoolDataSource_basic
=== PAUSE TestAccSESV2DedicatedIPPoolDataSource_basic
=== RUN   TestAccSESV2DedicatedIPPool_basic
=== PAUSE TestAccSESV2DedicatedIPPool_basic
=== RUN   TestAccSESV2DedicatedIPPool_disappears
=== PAUSE TestAccSESV2DedicatedIPPool_disappears
=== RUN   TestAccSESV2DedicatedIPPool_scalingMode
=== PAUSE TestAccSESV2DedicatedIPPool_scalingMode
=== RUN   TestAccSESV2DedicatedIPPool_tags
=== PAUSE TestAccSESV2DedicatedIPPool_tags
=== CONT  TestAccSESV2DedicatedIPPoolDataSource_basic
=== CONT  TestAccSESV2DedicatedIPPool_scalingMode
=== CONT  TestAccSESV2DedicatedIPPool_tags
--- PASS: TestAccSESV2DedicatedIPPoolDataSource_basic (12.72s)
=== CONT  TestAccSESV2DedicatedIPPool_disappears
=== CONT  TestAccSESV2DedicatedIPPool_basic
--- PASS: TestAccSESV2DedicatedIPPool_scalingMode (22.24s)
--- PASS: TestAccSESV2DedicatedIPPool_disappears (10.68s)
--- PASS: TestAccSESV2DedicatedIPPool_tags (29.60s)
--- PASS: TestAccSESV2DedicatedIPPool_basic (12.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	40.071s

% make testacc TESTARGS='-run=TestAccSESV2EmailIdentityDataSource_\|TestAccSESV2EmailIdentityFeedbackAttributes_\|TestAccSESV2EmailIdentityMailFromAttributesDataSource_\|TestAccSESV2EmailIdentityMailFromAttributes_\|TestAccSESV2EmailIdentity_' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2EmailIdentityDataSource_\|TestAccSESV2EmailIdentityFeedbackAttributes_\|TestAccSESV2EmailIdentityMailFromAttributesDataSource_\|TestAccSESV2EmailIdentityMailFromAttributes_\|TestAccSESV2EmailIdentity_ -timeout 360m
=== RUN   TestAccSESV2EmailIdentityDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityDataSource_basic
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_basic
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
=== RUN   TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== PAUSE TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
=== RUN   TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_basic
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_basic
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_disappears
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== RUN   TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
=== RUN   TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN   TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== RUN   TestAccSESV2EmailIdentity_disappears
=== PAUSE TestAccSESV2EmailIdentity_disappears
=== RUN   TestAccSESV2EmailIdentity_configurationSetName
=== PAUSE TestAccSESV2EmailIdentity_configurationSetName
=== RUN   TestAccSESV2EmailIdentity_nextSigningKeyLength
=== PAUSE TestAccSESV2EmailIdentity_nextSigningKeyLength
=== RUN   TestAccSESV2EmailIdentity_domainSigning
=== PAUSE TestAccSESV2EmailIdentity_domainSigning
=== RUN   TestAccSESV2EmailIdentity_tags
=== PAUSE TestAccSESV2EmailIdentity_tags
=== CONT  TestAccSESV2EmailIdentityDataSource_basic
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure
=== CONT  TestAccSESV2EmailIdentity_configurationSetName
--- PASS: TestAccSESV2EmailIdentityDataSource_basic (13.27s)
=== CONT  TestAccSESV2EmailIdentity_domainSigning
--- PASS: TestAccSESV2EmailIdentity_configurationSetName (23.95s)
=== CONT  TestAccSESV2EmailIdentity_tags
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_behaviorOnMXFailure (24.25s)
=== CONT  TestAccSESV2EmailIdentity_basic_domain
--- PASS: TestAccSESV2EmailIdentity_domainSigning (22.01s)
=== CONT  TestAccSESV2EmailIdentity_disappears
--- PASS: TestAccSESV2EmailIdentity_basic_domain (13.86s)
=== CONT  TestAccSESV2EmailIdentity_basic_emailAddress
--- PASS: TestAccSESV2EmailIdentity_disappears (10.81s)
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (13.05s)
=== CONT  TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
--- PASS: TestAccSESV2EmailIdentity_tags (29.05s)
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity
--- PASS: TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic (12.49s)
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_disappears
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_disappearsEmailIdentity (12.18s)
=== CONT  TestAccSESV2EmailIdentityMailFromAttributes_basic
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_mailFromDomain (22.21s)
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_disappears (12.40s)
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled
--- PASS: TestAccSESV2EmailIdentityMailFromAttributes_basic (14.40s)
=== CONT  TestAccSESV2EmailIdentity_nextSigningKeyLength
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears_emailIdentity (11.53s)
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_disappears
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_disappears (11.73s)
=== CONT  TestAccSESV2EmailIdentityFeedbackAttributes_basic
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_emailForwardingEnabled (21.34s)
--- PASS: TestAccSESV2EmailIdentity_nextSigningKeyLength (21.78s)
--- PASS: TestAccSESV2EmailIdentityFeedbackAttributes_basic (13.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	109.712s

% make testacc TESTARGS='-run=TestAccSESV2EmailIdentityPolicy_' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2EmailIdentityPolicy_ -timeout 360m
=== RUN   TestAccSESV2EmailIdentityPolicy_basic
=== PAUSE TestAccSESV2EmailIdentityPolicy_basic
=== RUN   TestAccSESV2EmailIdentityPolicy_disappears
=== PAUSE TestAccSESV2EmailIdentityPolicy_disappears
=== CONT  TestAccSESV2EmailIdentityPolicy_basic
=== CONT  TestAccSESV2EmailIdentityPolicy_disappears
--- PASS: TestAccSESV2EmailIdentityPolicy_disappears (12.78s)
--- PASS: TestAccSESV2EmailIdentityPolicy_basic (14.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	20.859s

ewbankkit · 2024-09-11T21:45:26Z

@acwwat Thanks for the contribution 🎉 👏.

github-actions · 2024-09-13T00:39:30Z

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-10-16T02:22:13Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/sesv2 Issues and PRs that pertain to the sesv2 service. labels Apr 13, 2024

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Apr 13, 2024

fix: Change event_destination.matching_event_types to Set to fix diff…

2353adc

… due to AWS-side sorting for aws_sesv2_configuration_set_event_destination

acwwat force-pushed the b-aws_sesv2_configuration_set_event_destination-fix_matching_event_types_diff branch from b508c78 to 2353adc Compare April 13, 2024 03:59

justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024

Merge branch 'main' into HEAD

e96a789

ewbankkit self-assigned this Sep 11, 2024

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 11, 2024

ewbankkit added 12 commits September 11, 2024 13:39

Tweak CHANGELOG entry.

7474d2f

sesv2: Reduce visibility.

f03664b

sesv2: Tidy up sweepers.

ce512d3

r/aws_sesv2_contact_list: Serialize acceptance tests.

13a5cea

r/aws_sesv2_configuration_set: Reduce visibility.

292aadc

r/aws_sesv2_configuration_set_event_destination: Reduce visibility.

8f8bf24

r/aws_sesv2_account_vdm_attributes: Reduce visibility.

c2ca9f5

r/aws_sesv2_dedicated_ip_assignment: Reduce visibility.

73c2f14

r/aws_sesv2_dedicated_ip_pool: Reduce visibility.

1b5aa36

r/aws_sesv2_email_identity: Reduce visibility.

717517d

r/aws_sesv2_email_identity_policy: Reduce visibility.

5fb45e5

ewbankkit requested a review from a team as a code owner September 11, 2024 21:12

ewbankkit approved these changes Sep 11, 2024

View reviewed changes

ewbankkit merged commit 597c672 into hashicorp:main Sep 11, 2024
40 checks passed

github-actions bot added this to the v5.67.0 milestone Sep 11, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024

acwwat deleted the b-aws_sesv2_configuration_set_event_destination-fix_matching_event_types_diff branch September 16, 2024 00:12

github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Change event_destination.matching_event_types to Set to fix diff due to AWS-side sorting for aws_sesv2_configuration_set_event_destination #36897

fix: Change event_destination.matching_event_types to Set to fix diff due to AWS-side sorting for aws_sesv2_configuration_set_event_destination #36897

acwwat commented Apr 13, 2024

github-actions bot commented Apr 13, 2024

ewbankkit left a comment

ewbankkit commented Sep 11, 2024

github-actions bot commented Sep 13, 2024

github-actions bot commented Oct 16, 2024

fix: Change event_destination.matching_event_types to Set to fix diff due to AWS-side sorting for aws_sesv2_configuration_set_event_destination #36897

fix: Change event_destination.matching_event_types to Set to fix diff due to AWS-side sorting for aws_sesv2_configuration_set_event_destination #36897

Conversation

acwwat commented Apr 13, 2024

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Apr 13, 2024

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Sep 11, 2024

github-actions bot commented Sep 13, 2024

github-actions bot commented Oct 16, 2024