-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a new 3rd party S3 (Naver Cloud Platform) #37801
Add support for a new 3rd party S3 (Naver Cloud Platform) #37801
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Hey @a3626a 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @a3626a 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@a3626a Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
By following exactly same approach from #23278, this PR adds support for a new 3rd party S3, Naver Cloud Platform.
Relations
Relates #23278
References
Output from Acceptance Testing
These 4 tests are consistently failing, even with main branch build.
These 2 test sometimes fail and sometimes succeed.
Notes
"Allow edits from maintainers" option is not available for organization forks.
(https://github.com/orgs/community/discussions/5634)
I think this is ok for this PR, becuase it is very small and following same approach of other PR which is already merge.
If some changes are required, let me know. I will do my best.