r/aws_cloudwatch_event_connection: fix expander assertions #38800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions
Changes the location of the type assertion to `[]interface{}` on all expanders to prevent nil values from triggering a crash.
```console
% make testacc PKG=events TESTS=TestAccEventsConnection_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsConnection_' -timeout 360m
--- PASS: TestAccEventsConnection_disappears (14.70s)
--- PASS: TestAccEventsConnection_invocationHTTPParameters (31.96s)
--- PASS: TestAccEventsConnection_apiKey (33.89s)
--- PASS: TestAccEventsConnection_basic (33.99s)
--- PASS: TestAccEventsConnection_oAuth (72.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 77.993s
```
Adjusts all expanders to check for nil items in an `[]interface{}` before asserting to `map[string]interface{}`.
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
service/events
```console % make testacc PKG=events TESTS=TestAccEventsConnection_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/events/... -v -count 1 -parallel 20 -run='TestAccEventsConnection_' -timeout 360m --- PASS: TestAccEventsConnection_disappears (15.30s) --- PASS: TestAccEventsConnection_invocationHTTPParameters (33.59s) --- PASS: TestAccEventsConnection_basic (35.75s) --- PASS: TestAccEventsConnection_apiKey (36.70s) --- PASS: TestAccEventsConnection_oAuth (69.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/events 75.894s ```
jar-b
added
bug
github-actions
bot
removed
the
prioritized
|
This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the location of the type assertion to
[]interface{}on all expanders to prevent nil values from triggering a crash. Adjusts all expanders to check for nil items in an[]interface{}before asserting tomap[string]interface{}.Relations
Closes #35326
Closes #31671
References
Output from Acceptance Testing