fixed iam role in ecr repository

[aleksandarknezevic]

Description

Fixes issue

Invalid parameter at 'PolicyText' failed to satisfy constraint: 'Principal not found'

when using newly created IAM role as a principal in ECR repository policy.

Relations

Closes #39064

References

Output from Acceptance Testing

% make testacc TESTS=TestAccECRRepositoryPolicy_  PKG=ecr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepositoryPolicy_'  -timeout 360m
=== RUN   TestAccECRRepositoryPolicy_basic
=== PAUSE TestAccECRRepositoryPolicy_basic
=== RUN   TestAccECRRepositoryPolicy_IAM_basic
=== PAUSE TestAccECRRepositoryPolicy_IAM_basic
=== RUN   TestAccECRRepositoryPolicy_IAM_principalOrder
=== PAUSE TestAccECRRepositoryPolicy_IAM_principalOrder
=== RUN   TestAccECRRepositoryPolicy_disappears
=== PAUSE TestAccECRRepositoryPolicy_disappears
=== RUN   TestAccECRRepositoryPolicy_Disappears_repository
=== PAUSE TestAccECRRepositoryPolicy_Disappears_repository
=== CONT  TestAccECRRepositoryPolicy_basic
=== CONT  TestAccECRRepositoryPolicy_disappears
=== CONT  TestAccECRRepositoryPolicy_Disappears_repository
=== CONT  TestAccECRRepositoryPolicy_IAM_principalOrder
=== CONT  TestAccECRRepositoryPolicy_IAM_basic
--- PASS: TestAccECRRepositoryPolicy_Disappears_repository (27.21s)
--- PASS: TestAccECRRepositoryPolicy_disappears (27.46s)
--- PASS: TestAccECRRepositoryPolicy_IAM_basic (39.32s)
--- PASS: TestAccECRRepositoryPolicy_basic (47.27s)
--- PASS: TestAccECRRepositoryPolicy_IAM_principalOrder (55.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        60.406s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @aleksandarknezevic 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jar-b]

LGTM 🎉

%  make testacc PKG=ecr TESTS="TestAccECRRepositoryPolicy_"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRRepositoryPolicy_'  -timeout 360m

--- PASS: TestAccECRRepositoryPolicy_Disappears_repository (15.25s)
--- PASS: TestAccECRRepositoryPolicy_disappears (15.46s)
--- PASS: TestAccECRRepositoryPolicy_IAM_basic (25.00s)
--- PASS: TestAccECRRepositoryPolicy_basic (26.78s)
--- PASS: TestAccECRRepositoryPolicy_IAM_principalOrder (33.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        40.100s

[jar-b]

Thanks for your contribution, @aleksandarknezevic! 👍

[github-actions]

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.