datasource/aws_cognito_user_pool: Fixes value conversion error

[gdavison]

Description

Fixes value conversion error in data source aws_cognito_user_pool. Data type was not identified because a non-standard attribute name was used in the schema.

Deprecates non-standard attribute user_pool_tags and adds standard attribute tags.

Relations

Closes #39183.
Closes #39245.

References

Output from Acceptance Testing

% make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPoolDataSource_

--- PASS: TestAccCognitoIDPUserPoolDataSource_tags (12.99s)
--- PASS: TestAccCognitoIDPUserPoolDataSource_schemaAttributes (13.87s)
--- PASS: TestAccCognitoIDPUserPoolDataSource_userPoolTags (14.52s)
--- PASS: TestAccCognitoIDPUserPoolDataSource_basic (14.63s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolDataSource_' PKG=cognitoidp ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/cognitoidp/... -v -count 1 -parallel 3  -run=TestAccCognitoIDPUserPoolDataSource_ -timeout 360m
=== RUN   TestAccCognitoIDPUserPoolDataSource_tags
=== PAUSE TestAccCognitoIDPUserPoolDataSource_tags
=== RUN   TestAccCognitoIDPUserPoolDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolDataSource_basic
=== RUN   TestAccCognitoIDPUserPoolDataSource_schemaAttributes
=== PAUSE TestAccCognitoIDPUserPoolDataSource_schemaAttributes
=== RUN   TestAccCognitoIDPUserPoolDataSource_userPoolTags
=== PAUSE TestAccCognitoIDPUserPoolDataSource_userPoolTags
=== CONT  TestAccCognitoIDPUserPoolDataSource_tags
=== CONT  TestAccCognitoIDPUserPoolDataSource_schemaAttributes
=== CONT  TestAccCognitoIDPUserPoolDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolDataSource_tags (12.63s)
=== CONT  TestAccCognitoIDPUserPoolDataSource_userPoolTags
--- PASS: TestAccCognitoIDPUserPoolDataSource_schemaAttributes (13.16s)
--- PASS: TestAccCognitoIDPUserPoolDataSource_basic (13.81s)
--- PASS: TestAccCognitoIDPUserPoolDataSource_userPoolTags (13.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	31.091s

[github-actions]

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.