Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/opensearchserverless_access_policy: policy is not set correctly #39322

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Sep 13, 2024

Description

Autoflex type check for Interface type checks that the interface is implemented

Relations

Closes #39319

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccOpenSearchServerlessAccessPolicy_' PKG=opensearchserverless

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20  -run=TestAccOpenSearchServerlessAccessPolicy_ -timeout 360m
--- PASS: TestAccOpenSearchServerlessAccessPolicy_disappears (13.68s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_basic (16.03s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_update (32.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	38.603s.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 13, 2024
@johnsonaj johnsonaj marked this pull request as ready for review September 13, 2024 17:02
@johnsonaj johnsonaj requested a review from a team as a code owner September 13, 2024 17:02
@jar-b jar-b self-assigned this Sep 13, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=opensearchserverless TESTS=TestAccOpenSearchServerlessAccessPolicy_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessAccessPolicy_'  -timeout 360m

--- PASS: TestAccOpenSearchServerlessAccessPolicy_disappears (14.07s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_basic (15.78s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_update (32.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless       38.894s

@johnsonaj johnsonaj merged commit e610c2c into main Sep 13, 2024
46 checks passed
@johnsonaj johnsonaj deleted the b-autoflex_smithyjson branch September 13, 2024 17:44
@github-actions github-actions bot added this to the v5.68.0 milestone Sep 13, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Sep 13, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_opensearchserverless_access_policy "Provider produced inconsistent result after apply"
2 participants