r/aws_ses_receipt_rule: add `iam_role_arn` argument to `s3_action` configuration block #39364

kamilturek · 2024-09-17T20:30:30Z

Description

This PR adds the iam_role_arn argument to the s3_action configuration block.

Relations

References

https://docs.aws.amazon.com/ses/latest/APIReference/API_S3Action.html

Output from Acceptance Testing

% make testacc PKG=ses ACCTEST_PARALLELISM=1 TESTARGS="-run=TestAccSESReceiptRule_s3Action"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/ses/... -v -count 1 -parallel 1  -run=TestAccSESReceiptRule_s3Action -timeout 360m
=== RUN   TestAccSESReceiptRule_s3Action
=== PAUSE TestAccSESReceiptRule_s3Action
=== RUN   TestAccSESReceiptRule_s3Action_iamRoleArn
=== PAUSE TestAccSESReceiptRule_s3Action_iamRoleArn
=== CONT  TestAccSESReceiptRule_s3Action
--- PASS: TestAccSESReceiptRule_s3Action (31.59s)
=== CONT  TestAccSESReceiptRule_s3Action_iamRoleArn
--- PASS: TestAccSESReceiptRule_s3Action_iamRoleArn (30.96s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ses        67.353s

github-actions · 2024-09-17T20:30:44Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESActiveReceiptRuleSet_serial' PKG=ses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 20  -run=TestAccSESActiveReceiptRuleSet_serial -timeout 360m
=== RUN   TestAccSESActiveReceiptRuleSet_serial
=== PAUSE TestAccSESActiveReceiptRuleSet_serial
=== CONT  TestAccSESActiveReceiptRuleSet_serial
=== RUN   TestAccSESActiveReceiptRuleSet_serial/Resource
=== RUN   TestAccSESActiveReceiptRuleSet_serial/Resource/basic
=== RUN   TestAccSESActiveReceiptRuleSet_serial/Resource/disappears
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource/basic
=== RUN   TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet
--- PASS: TestAccSESActiveReceiptRuleSet_serial (39.10s)
    --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource (25.99s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/basic (14.65s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/disappears (11.34s)
    --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource (13.11s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/basic (11.26s)
        --- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet (1.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	44.370s

% make testacc TESTARGS='-run=TestAccSESConfigurationSet_' PKG=ses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 20  -run=TestAccSESConfigurationSet_ -timeout 360m
=== RUN   TestAccSESConfigurationSet_basic
=== PAUSE TestAccSESConfigurationSet_basic
=== RUN   TestAccSESConfigurationSet_sendingEnabled
=== PAUSE TestAccSESConfigurationSet_sendingEnabled
=== RUN   TestAccSESConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESConfigurationSet_deliveryOptions
=== PAUSE TestAccSESConfigurationSet_deliveryOptions
=== RUN   TestAccSESConfigurationSet_Update_deliveryOptions
=== PAUSE TestAccSESConfigurationSet_Update_deliveryOptions
=== RUN   TestAccSESConfigurationSet_emptyDeliveryOptions
=== PAUSE TestAccSESConfigurationSet_emptyDeliveryOptions
=== RUN   TestAccSESConfigurationSet_Update_emptyDeliveryOptions
=== PAUSE TestAccSESConfigurationSet_Update_emptyDeliveryOptions
=== RUN   TestAccSESConfigurationSet_disappears
=== PAUSE TestAccSESConfigurationSet_disappears
=== CONT  TestAccSESConfigurationSet_basic
=== CONT  TestAccSESConfigurationSet_emptyDeliveryOptions
=== CONT  TestAccSESConfigurationSet_deliveryOptions
=== CONT  TestAccSESConfigurationSet_reputationMetricsEnabled
=== CONT  TestAccSESConfigurationSet_disappears
=== CONT  TestAccSESConfigurationSet_Update_emptyDeliveryOptions
=== CONT  TestAccSESConfigurationSet_Update_deliveryOptions
=== CONT  TestAccSESConfigurationSet_sendingEnabled
--- PASS: TestAccSESConfigurationSet_disappears (16.20s)
--- PASS: TestAccSESConfigurationSet_deliveryOptions (18.03s)
--- PASS: TestAccSESConfigurationSet_basic (18.31s)
--- PASS: TestAccSESConfigurationSet_emptyDeliveryOptions (18.38s)
--- PASS: TestAccSESConfigurationSet_reputationMetricsEnabled (33.65s)
--- PASS: TestAccSESConfigurationSet_sendingEnabled (33.67s)
--- PASS: TestAccSESConfigurationSet_Update_emptyDeliveryOptions (35.59s)
--- PASS: TestAccSESConfigurationSet_Update_deliveryOptions (42.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	47.235s

% make testacc TESTARGS='-run=TestAccSESDomainDKIM_' PKG=ses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 20  -run=TestAccSESDomainDKIM_ -timeout 360m
=== RUN   TestAccSESDomainDKIM_basic
=== PAUSE TestAccSESDomainDKIM_basic
=== RUN   TestAccSESDomainDKIM_Disappears_identity
=== PAUSE TestAccSESDomainDKIM_Disappears_identity
=== CONT  TestAccSESDomainDKIM_basic
=== CONT  TestAccSESDomainDKIM_Disappears_identity
--- PASS: TestAccSESDomainDKIM_Disappears_identity (12.72s)
--- PASS: TestAccSESDomainDKIM_basic (12.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	17.860s

% SES_DOMAIN_IDENTITY_ROOT_DOMAIN=... make testacc TESTARGS='-run=TestAccSESDomainIdentityVerification_' PKG=ses
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 20  -run=TestAccSESDomainIdentityVerification_ -timeout 360m
=== RUN   TestAccSESDomainIdentityVerification_basic
=== PAUSE TestAccSESDomainIdentityVerification_basic
=== RUN   TestAccSESDomainIdentityVerification_timeout
=== PAUSE TestAccSESDomainIdentityVerification_timeout
=== RUN   TestAccSESDomainIdentityVerification_nonexistent
=== PAUSE TestAccSESDomainIdentityVerification_nonexistent
=== CONT  TestAccSESDomainIdentityVerification_basic
=== CONT  TestAccSESDomainIdentityVerification_nonexistent
=== CONT  TestAccSESDomainIdentityVerification_timeout
--- PASS: TestAccSESDomainIdentityVerification_nonexistent (4.63s)
--- PASS: TestAccSESDomainIdentityVerification_timeout (11.55s)
--- PASS: TestAccSESDomainIdentityVerification_basic (112.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	117.641s

% make testacc TESTARGS='-run=TestAccSESDomainIdentityDataSource_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESDomainIdentityDataSource_ -timeout 360m
=== RUN   TestAccSESDomainIdentityDataSource_basic
=== PAUSE TestAccSESDomainIdentityDataSource_basic
=== CONT  TestAccSESDomainIdentityDataSource_basic
--- PASS: TestAccSESDomainIdentityDataSource_basic (11.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	16.452s

% make testacc TESTARGS='-run=TestAccSESDomainIdentity_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESDomainIdentity_ -timeout 360m
=== RUN   TestAccSESDomainIdentity_basic
=== PAUSE TestAccSESDomainIdentity_basic
=== RUN   TestAccSESDomainIdentity_disappears
=== PAUSE TestAccSESDomainIdentity_disappears
=== RUN   TestAccSESDomainIdentity_trailingPeriod
=== PAUSE TestAccSESDomainIdentity_trailingPeriod
=== CONT  TestAccSESDomainIdentity_basic
=== CONT  TestAccSESDomainIdentity_trailingPeriod
=== CONT  TestAccSESDomainIdentity_disappears
--- PASS: TestAccSESDomainIdentity_trailingPeriod (1.67s)
--- PASS: TestAccSESDomainIdentity_basic (10.86s)
--- PASS: TestAccSESDomainIdentity_disappears (11.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	16.546s

% make testacc TESTARGS='-run=TestAccSESDomainMailFrom_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESDomainMailFrom_ -timeout 360m
=== RUN   TestAccSESDomainMailFrom_basic
=== PAUSE TestAccSESDomainMailFrom_basic
=== RUN   TestAccSESDomainMailFrom_disappears
=== PAUSE TestAccSESDomainMailFrom_disappears
=== RUN   TestAccSESDomainMailFrom_Disappears_identity
=== PAUSE TestAccSESDomainMailFrom_Disappears_identity
=== RUN   TestAccSESDomainMailFrom_behaviorOnMxFailure
=== PAUSE TestAccSESDomainMailFrom_behaviorOnMxFailure
=== CONT  TestAccSESDomainMailFrom_basic
=== CONT  TestAccSESDomainMailFrom_Disappears_identity
=== CONT  TestAccSESDomainMailFrom_disappears
--- PASS: TestAccSESDomainMailFrom_disappears (12.15s)
=== CONT  TestAccSESDomainMailFrom_behaviorOnMxFailure
--- PASS: TestAccSESDomainMailFrom_Disappears_identity (12.19s)
--- PASS: TestAccSESDomainMailFrom_basic (21.59s)
--- PASS: TestAccSESDomainMailFrom_behaviorOnMxFailure (20.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	37.630s

% make testacc TESTARGS='-run=TestAccSESEmailIdentity_serial' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESEmailIdentity_serial -timeout 360m
=== RUN   TestAccSESEmailIdentity_serial
=== PAUSE TestAccSESEmailIdentity_serial
=== CONT  TestAccSESEmailIdentity_serial
=== RUN   TestAccSESEmailIdentity_serial/basic
=== RUN   TestAccSESEmailIdentity_serial/disappears
=== RUN   TestAccSESEmailIdentity_serial/trailingPeriod
=== RUN   TestAccSESEmailIdentity_serial/dataSource_basic
=== RUN   TestAccSESEmailIdentity_serial/dataSource_trailingPeriod
--- PASS: TestAccSESEmailIdentity_serial (57.73s)
    --- PASS: TestAccSESEmailIdentity_serial/basic (13.19s)
    --- PASS: TestAccSESEmailIdentity_serial/disappears (10.73s)
    --- PASS: TestAccSESEmailIdentity_serial/trailingPeriod (12.48s)
    --- PASS: TestAccSESEmailIdentity_serial/dataSource_basic (10.70s)
    --- PASS: TestAccSESEmailIdentity_serial/dataSource_trailingPeriod (10.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	62.714s

% make testacc TESTARGS='-run=TestAccSESEventDestination_' PKG=ses ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESEventDestination_ -timeout 360m
=== RUN   TestAccSESEventDestination_basic
=== PAUSE TestAccSESEventDestination_basic
=== RUN   TestAccSESEventDestination_disappears
=== PAUSE TestAccSESEventDestination_disappears
=== RUN   TestAccSESEventDestination_Disappears_configurationSet
=== PAUSE TestAccSESEventDestination_Disappears_configurationSet
=== RUN   TestAccSESEventDestination_firehose
=== PAUSE TestAccSESEventDestination_firehose
=== RUN   TestAccSESEventDestination_sns
=== PAUSE TestAccSESEventDestination_sns
=== RUN   TestAccSESEventDestination_multiple
=== PAUSE TestAccSESEventDestination_multiple
=== CONT  TestAccSESEventDestination_basic
=== CONT  TestAccSESEventDestination_multiple
=== CONT  TestAccSESEventDestination_firehose
--- PASS: TestAccSESEventDestination_basic (14.28s)
=== CONT  TestAccSESEventDestination_sns
--- PASS: TestAccSESEventDestination_sns (14.60s)
=== CONT  TestAccSESEventDestination_Disappears_configurationSet
--- PASS: TestAccSESEventDestination_Disappears_configurationSet (10.93s)
=== CONT  TestAccSESEventDestination_disappears
--- PASS: TestAccSESEventDestination_disappears (10.80s)
--- PASS: TestAccSESEventDestination_firehose (62.76s)
--- PASS: TestAccSESEventDestination_multiple (68.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	73.225s

% make testacc TESTARGS='-run=TestAccSESIdentityNotificationTopic_' PKG=ses ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESIdentityNotificationTopic_ -timeout 360m
=== RUN   TestAccSESIdentityNotificationTopic_basic
=== PAUSE TestAccSESIdentityNotificationTopic_basic
=== CONT  TestAccSESIdentityNotificationTopic_basic
--- PASS: TestAccSESIdentityNotificationTopic_basic (31.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	36.627s

% make testacc TESTARGS='-run=TestAccSESIdentityPolicy_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESIdentityPolicy_ -timeout 360m
=== RUN   TestAccSESIdentityPolicy_basic
=== PAUSE TestAccSESIdentityPolicy_basic
=== RUN   TestAccSESIdentityPolicy_Identity_email
=== PAUSE TestAccSESIdentityPolicy_Identity_email
=== RUN   TestAccSESIdentityPolicy_policy
=== PAUSE TestAccSESIdentityPolicy_policy
=== RUN   TestAccSESIdentityPolicy_ignoreEquivalent
=== PAUSE TestAccSESIdentityPolicy_ignoreEquivalent
=== CONT  TestAccSESIdentityPolicy_basic
=== CONT  TestAccSESIdentityPolicy_policy
=== CONT  TestAccSESIdentityPolicy_Identity_email
--- PASS: TestAccSESIdentityPolicy_Identity_email (14.29s)
=== CONT  TestAccSESIdentityPolicy_ignoreEquivalent
--- PASS: TestAccSESIdentityPolicy_basic (14.29s)
--- PASS: TestAccSESIdentityPolicy_policy (22.07s)
--- PASS: TestAccSESIdentityPolicy_ignoreEquivalent (14.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	34.061s

% make testacc TESTARGS='-run=TestAccSESReceiptFilter_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESReceiptFilter_ -timeout 360m
=== RUN   TestAccSESReceiptFilter_basic
=== PAUSE TestAccSESReceiptFilter_basic
=== RUN   TestAccSESReceiptFilter_disappears
=== PAUSE TestAccSESReceiptFilter_disappears
=== CONT  TestAccSESReceiptFilter_basic
=== CONT  TestAccSESReceiptFilter_disappears
--- PASS: TestAccSESReceiptFilter_disappears (11.58s)
--- PASS: TestAccSESReceiptFilter_basic (13.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	18.720s

% make testacc TESTARGS='-run=TestAccSESReceiptRule_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESReceiptRule_ -timeout 360m
=== RUN   TestAccSESReceiptRule_basic
=== PAUSE TestAccSESReceiptRule_basic
=== RUN   TestAccSESReceiptRule_s3Action
=== PAUSE TestAccSESReceiptRule_s3Action
=== RUN   TestAccSESReceiptRule_s3Action_iamRoleARN
=== PAUSE TestAccSESReceiptRule_s3Action_iamRoleARN
=== RUN   TestAccSESReceiptRule_snsAction
=== PAUSE TestAccSESReceiptRule_snsAction
=== RUN   TestAccSESReceiptRule_snsActionEncoding
=== PAUSE TestAccSESReceiptRule_snsActionEncoding
=== RUN   TestAccSESReceiptRule_lambdaAction
=== PAUSE TestAccSESReceiptRule_lambdaAction
=== RUN   TestAccSESReceiptRule_stopAction
=== PAUSE TestAccSESReceiptRule_stopAction
=== RUN   TestAccSESReceiptRule_order
=== PAUSE TestAccSESReceiptRule_order
=== RUN   TestAccSESReceiptRule_actions
=== PAUSE TestAccSESReceiptRule_actions
=== RUN   TestAccSESReceiptRule_disappears
=== PAUSE TestAccSESReceiptRule_disappears
=== CONT  TestAccSESReceiptRule_basic
=== CONT  TestAccSESReceiptRule_lambdaAction
=== CONT  TestAccSESReceiptRule_actions
--- PASS: TestAccSESReceiptRule_basic (13.93s)
--- PASS: TestAccSESReceiptRule_actions (13.93s)
=== CONT  TestAccSESReceiptRule_disappears
=== CONT  TestAccSESReceiptRule_order
--- PASS: TestAccSESReceiptRule_disappears (11.43s)
=== CONT  TestAccSESReceiptRule_snsAction
--- PASS: TestAccSESReceiptRule_order (13.67s)
=== CONT  TestAccSESReceiptRule_snsActionEncoding
--- PASS: TestAccSESReceiptRule_lambdaAction (30.48s)
=== CONT  TestAccSESReceiptRule_s3Action_iamRoleARN
--- PASS: TestAccSESReceiptRule_snsAction (14.03s)
=== CONT  TestAccSESReceiptRule_stopAction
--- PASS: TestAccSESReceiptRule_snsActionEncoding (13.91s)
=== CONT  TestAccSESReceiptRule_s3Action
--- PASS: TestAccSESReceiptRule_stopAction (14.16s)
--- PASS: TestAccSESReceiptRule_s3Action_iamRoleARN (23.96s)
--- PASS: TestAccSESReceiptRule_s3Action (19.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	66.579s

% make testacc TESTARGS='-run=TestAccSESReceiptRuleSet_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESReceiptRuleSet_ -timeout 360m
=== RUN   TestAccSESReceiptRuleSet_basic
=== PAUSE TestAccSESReceiptRuleSet_basic
=== RUN   TestAccSESReceiptRuleSet_disappears
=== PAUSE TestAccSESReceiptRuleSet_disappears
=== CONT  TestAccSESReceiptRuleSet_basic
=== CONT  TestAccSESReceiptRuleSet_disappears
--- PASS: TestAccSESReceiptRuleSet_disappears (11.41s)
--- PASS: TestAccSESReceiptRuleSet_basic (13.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	18.447s

% make testacc TESTARGS='-run=TestAccSESTemplate_' PKG=ses ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ses/... -v -count 1 -parallel 3  -run=TestAccSESTemplate_ -timeout 360m
=== RUN   TestAccSESTemplate_basic
=== PAUSE TestAccSESTemplate_basic
=== RUN   TestAccSESTemplate_update
=== PAUSE TestAccSESTemplate_update
=== RUN   TestAccSESTemplate_disappears
=== PAUSE TestAccSESTemplate_disappears
=== CONT  TestAccSESTemplate_basic
=== CONT  TestAccSESTemplate_disappears
=== CONT  TestAccSESTemplate_update
--- PASS: TestAccSESTemplate_disappears (11.73s)
--- PASS: TestAccSESTemplate_basic (13.69s)
--- PASS: TestAccSESTemplate_update (29.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	34.059s

ewbankkit · 2024-09-19T19:02:25Z

@kamilturek Thanks for the contribution 🎉 👏.

github-actions · 2024-09-20T12:41:51Z

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2024-10-22T02:22:18Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ses Issues and PRs that pertain to the ses service. labels Sep 17, 2024

Add iam_role_arn argument to s3_action configuration block

8b799c9

github-actions bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Sep 17, 2024

kamilturek added 2 commits September 17, 2024 22:31

Update docs

9f352ed

Add changelog

ceccc06

kamilturek force-pushed the f-aws-ses-receipt-rule-s3-action-iam-role-arn branch from 2a6fc64 to ceccc06 Compare September 17, 2024 20:32

kamilturek added 3 commits September 17, 2024 22:34

Ignore semgrep error

dfcca10

Fix caps

ab507dc

Check retry.RetryContext() errors with tfresource.TimedOut()

4e54671

kamilturek marked this pull request as ready for review September 17, 2024 21:11

kamilturek requested a review from a team as a code owner September 17, 2024 21:11

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 18, 2024

ewbankkit self-assigned this Sep 18, 2024

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 18, 2024

ewbankkit added 12 commits September 18, 2024 10:59

Merge branch 'main' into HEAD

20b59d2

r/aws_ses_receipt_rule: Tidy up.

2b33a40

r/aws_ses_receipt_rule_set: Tidy up.

4c2a156

r/aws_ses_template: Tidy up.

d169178

r/aws_ses_receipt_filter: Tidy up.

a0cde56

r/aws_ses_identity_policy: Tidy up.

0cc94dc

Add 'TestAccSESReceiptRule_Disappears_receiptRuleSet'.

5870c21

r/aws_ses_identity_notification_topic: Tidy up.

14eb02d

r/aws_ses_event_destination: Tidy up.

7fe4e28

r/aws_ses_event_destination: Additional acceptance tests.

f67c9c0

r/aws_ses_email_identity: Tidy up.

0223eca

r/aws_ses_email_identity: Serialize acceptance tests.

3d9bf3f

ewbankkit added 13 commits September 19, 2024 11:32

d/aws_ses_email_identity: Tidy up.

e2b8c26

Correct source file name.

8d0dc2a

r/aws_ses_domain_mail_from: Tidy up.

878c904

r/aws_ses_domain_identity: Tidy up.

ba378f2

d/aws_ses_domain_identity: Tidy up.

d51b69e

r/aws_ses_domain_identity_verification: Tidy up.

6bb7b8b

r/aws_ses_domain_dkim: Tidy up.

47dbe73

r/aws_ses_configuration_set: Tidy up.

defb84b

r/aws_ses_active_receipt_rule_set: Tidy up.

97a25cf

d/aws_ses_active_receipt_rule_set: Tidy up.

b16667c

Fix semgrep 'ci.typed-enum-conversion'.

f1f33ea

Run 'make fix-constants PKG=ses'.

d0a8bbe

Run 'make fmt'.

73f271f

ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 19, 2024

ewbankkit approved these changes Sep 19, 2024

View reviewed changes

ewbankkit merged commit dbc0ac9 into hashicorp:main Sep 19, 2024
47 checks passed

github-actions bot added this to the v5.68.0 milestone Sep 19, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024

github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_ses_receipt_rule: add `iam_role_arn` argument to `s3_action` configuration block #39364

r/aws_ses_receipt_rule: add `iam_role_arn` argument to `s3_action` configuration block #39364

kamilturek commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

ewbankkit left a comment

ewbankkit commented Sep 19, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Oct 22, 2024

r/aws_ses_receipt_rule: add iam_role_arn argument to s3_action configuration block #39364

r/aws_ses_receipt_rule: add iam_role_arn argument to s3_action configuration block #39364

Conversation

kamilturek commented Sep 17, 2024

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Sep 17, 2024

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Sep 19, 2024

github-actions bot commented Sep 20, 2024

github-actions bot commented Oct 22, 2024

r/aws_ses_receipt_rule: add `iam_role_arn` argument to `s3_action` configuration block #39364

r/aws_ses_receipt_rule: add `iam_role_arn` argument to `s3_action` configuration block #39364