Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data_source for aws_elasticache_serverless_cache #39590

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Add data_source for aws_elasticache_serverless_cache #39590

merged 4 commits into from
Oct 10, 2024
+329 −2

Conversation

vtstanescu
Copy link
Contributor

Description

Adds aws_elasticache_serverless_cache data source to complement the resource.

Relations

Closes #35469

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheServerlessCacheDataSource_basic'  -timeout 360m
=== RUN   TestAccElastiCacheServerlessCacheDataSource_basic
=== PAUSE TestAccElastiCacheServerlessCacheDataSource_basic
=== CONT  TestAccElastiCacheServerlessCacheDataSource_basic
--- PASS: TestAccElastiCacheServerlessCacheDataSource_basic (300.03s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        305.245s

@vtstanescu vtstanescu requested a review from a team as a code owner October 4, 2024 10:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elasticache Issues and PRs that pertain to the elasticache service. service/appstream Issues and PRs that pertain to the appstream service. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. labels Oct 4, 2024
@vtstanescu vtstanescu force-pushed the f-elasticache-serverless-cache branch 2 times, most recently from d6cc676 to 7aa51c4 Compare October 4, 2024 10:15
@vtstanescu vtstanescu force-pushed the f-elasticache-serverless-cache branch from 7aa51c4 to 95376f6 Compare October 4, 2024 10:36
@johnsonaj johnsonaj self-assigned this Oct 10, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 10, 2024
johnsonaj
johnsonaj approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccElastiCacheServerlessCacheDataSource_basic' PKG=elasticache

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elasticache/... -v -count 1 -parallel 20  -run=TestAccElastiCacheServerlessCacheDataSource_basic -timeout 360m
2024/10/10 10:54:31 Initializing Terraform AWS Provider...
=== RUN   TestAccElastiCacheServerlessCacheDataSource_basic
=== PAUSE TestAccElastiCacheServerlessCacheDataSource_basic
=== CONT  TestAccElastiCacheServerlessCacheDataSource_basic
--- PASS: TestAccElastiCacheServerlessCacheDataSource_basic (355.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	362.060s

@johnsonaj johnsonaj added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 10, 2024
@johnsonaj
Copy link
Contributor

@vtstanescu thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit a2aa1ff into hashicorp:main Oct 10, 2024
48 checks passed
@github-actions github-actions bot added this to the v5.71.0 milestone Oct 10, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees

@johnsonaj johnsonaj

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/appstream Issues and PRs that pertain to the appstream service. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.72.0
Development

Successfully merging this pull request may close these issues.

[New Data Source]: Missing data_source for aws_elasticache_serverless_cache
2 participants
@vtstanescu @johnsonaj