Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support Sharepoint type in aws_bedrockagent_data_source #39770

Closed
TheBlaide opened this issue Oct 17, 2024 · 3 comments · Fixed by #40711
Closed

[Enhancement]: Support Sharepoint type in aws_bedrockagent_data_source #39770

TheBlaide opened this issue Oct 17, 2024 · 3 comments · Fixed by #40711
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/bedrockagent Issues and PRs that pertain to the bedrockagent service.
Milestone

Comments

@TheBlaide
Copy link

TheBlaide commented Oct 17, 2024

Description

is Sharepoint datasource already supported in aws_bedrockagent_data_source ?

aws bedrock-agent get-data-source --knowledge-base-id XXXXXXXX --data-source-id XXXXXXXXX
{
    "dataSource": {
        "createdAt": "2024-10-11T09:50:58.907091+00:00",
        "dataDeletionPolicy": "DELETE",
        "dataSourceConfiguration": {
            "sharePointConfiguration": {
                "crawlerConfiguration": {
                    "filterConfiguration": {
                        "patternObjectFilter": {
                            "filters": [
                                {
                                    "exclusionFilters": [
                                        ".*abcd.*",
                                        ".*wxyz.*"
                                    ],
                                    "objectType": "Page"
                                },
                                {
                                    "inclusionFilters": [
                                        "aspx"
                                    ],
                                    "objectType": "File"
                                }
                            ]
                        },
                        "type": "PATTERN"
                    }
                },
                "sourceConfiguration": {
                    "authType": "OAUTH2_CLIENT_CREDENTIALS",
                    "credentialsSecretArn": "arn:aws:secretsmanager:eu-west-3:xxxxxxxx:secret:xxxxxx",
                    "domain": "xxxxxxxxxxxx",
                    "hostType": "ONLINE",
                    "siteUrls": [
                        "https://xxxxxxx.sharepoint.com/sites/intranet"
                    ],
                    "tenantId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
                }
            },
            "type": "SHAREPOINT"
        },
        "dataSourceId": "XXXXXXXX",
        "knowledgeBaseId": "XXXXXXXXX",
        "name": "live-kb",
        "status": "AVAILABLE",
        "updatedAt": "2024-10-16T09:25:34.979982+00:00",
        "vectorIngestionConfiguration": {}
    }
}

Affected Resource(s) and/or Data Source(s)

aws_bedrockagent_data_source

Potential Terraform Configuration

resource "aws_bedrockagent_data_source" "example" {
    knowledge_base_id = aws_bedrockagent_knowledge_base.example.id
    name              = "example"
    data_source_configuration {
      type = "SHAREPOINT"
      sharepoint_configuration {
        crawler_configuration{
          filterConfiguration{
            type = "PATTERN"
            pattern_object_filter{
              filters = [
                {
                  exclusion_filters = [".*abcd.*",".*wxyz.*"]
                  object_type = "Page"
                },
                {
                  inclusion_filters = ["aspx"]
                  object_type = "File"
                }
              ]
            }
          }
        }
        source_configuration{
          auth_type = "OAUTH2_CLIENT_CREDENTIALS"
          credentials_secret_arn = "arn:aws:secretsmanager:eu-west-3:xxxxxxxx:secret:xxxxxx"
          domain = "mydomain"
          host_type = "ONLINE"
          site_urls = ["https://intmydomain.sharepoint.com/sites/intranet"]
          tenant_id =  "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
        }
      }
    }
  }

References

No response

Would you like to implement a fix?

None

@TheBlaide TheBlaide added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 17, 2024
@github-actions github-actions bot added the service/bedrockagent Issues and PRs that pertain to the bedrockagent service. label Oct 17, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 17, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 21, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.85.0 milestone Jan 30, 2025
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/bedrockagent Issues and PRs that pertain to the bedrockagent service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants