Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lambda: Ephemeral resource aws_lambda_invocation #39988

Merged
merged 25 commits into from
Nov 20, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Nov 1, 2024

Description

Thoughts on an ephemeral resource for Lambda function invocations?

Relations

Depends #39835
Depends #40203
Relates #40009

References

Output from Acceptance Testing

% make t T=TestAccLambdaInvocationEphemeral_basic K=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvocationEphemeral_basic'  -timeout 360m
2024/11/20 16:50:43 Initializing Terraform AWS Provider...
=== RUN   TestAccLambdaInvocationEphemeral_basic
=== PAUSE TestAccLambdaInvocationEphemeral_basic
=== CONT  TestAccLambdaInvocationEphemeral_basic
--- PASS: TestAccLambdaInvocationEphemeral_basic (27.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	31.716s

Copy link

github-actions bot commented Nov 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/kms Issues and PRs that pertain to the kms service. provider Pertains to the provider itself, rather than any interaction with AWS. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 1, 2024
@johnsonaj johnsonaj added the new-ephemeral-resource Introduces a new ephemeral resource. label Nov 4, 2024
@github-actions github-actions bot added the linter Pertains to changes to or issues with the various linters. label Nov 19, 2024
@github-actions github-actions bot added the create Pertains to generating names, hashcodes, etc. label Nov 19, 2024
@YakDriver YakDriver marked this pull request as ready for review November 20, 2024 21:51
@YakDriver YakDriver requested a review from a team as a code owner November 20, 2024 21:51
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver merged commit 752ffa2 into main Nov 20, 2024
41 of 42 checks passed
@YakDriver YakDriver deleted the f-ephemeral-lambda-invocation branch November 20, 2024 22:26
@github-actions github-actions bot added this to the v5.77.0 milestone Nov 20, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 20, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2024
Copy link

This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. create Pertains to generating names, hashcodes, etc. documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. new-ephemeral-resource Introduces a new ephemeral resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/kms Issues and PRs that pertain to the kms service. service/lambda Issues and PRs that pertain to the lambda service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants