feat: update max length for bedrock agent instructions

[stefanfreitag]

Description

The optional instruction argument of the resource aws_bedrock_agent has a length limitation. In the AWS provider a validation has been put in place to fail-fast on invalid inputs. In the current provider version the allowed range for instruction is 40 - 4000 character.

AWS increased the maximum number of characters to 8000.
This can be verified by checking the default account level quota, e.g. via

❯ aws service-quotas get-service-quota --service-code bedrock --quota-code L-6E3CDA2D --output table

The output of above command is

-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
|                                                                                                         GetServiceQuota                                                                                                         |
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
||                                                                                                             Quota                                                                                                             ||
|+------------+--------------+----------------------+----------------------------------------------------------------------+-------------+-----------------------------------+--------------+-----------------+-------+----------+|
|| Adjustable | GlobalQuota  | QuotaAppliedAtLevel  |                              QuotaArn                                |  QuotaCode  |             QuotaName             | ServiceCode  |   ServiceName   | Unit  |  Value   ||
|+------------+--------------+----------------------+----------------------------------------------------------------------+-------------+-----------------------------------+--------------+-----------------+-------+----------+|
||  True      |  False       |  ACCOUNT             |  arn:aws:servicequotas:eu-central-1:<redacted>:bedrock/L-6E3CDA2D  |  L-6E3CDA2D |  Characters in Agent instructions |  bedrock     |  Amazon Bedrock |  None |  8000.0  ||
|+------------+--------------+----------------------+----------------------------------------------------------------------+-------------+-----------------------------------+--------------+-----------------+-------+----------+|

Relations

• Closes [Bug]: aws_bedrockagent_agent "instruction" attribute validator max should be changed from 4000 to 8000 #40236
  The original issue
• Relates [Bug]: Bedrock Agent instruction is mandatory #40255 and fix(aws_bedrockagent_agent): argument instruction is mandatory #40256
  Another issue and pull request touching the instruction argument of the resource aws_bedrock_agent.

References

• (Outdated) Bedrock API reference

Output from Acceptance Testing

❯ make testacc TESTS=TestAccBedrockAgentAgent PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgent'  -timeout 360m
2024/11/23 21:40:35 Initializing Terraform AWS Provider...
=== RUN   TestAccBedrockAgentAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentAgentActionGroup_basic
=== RUN   TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent
=== PAUSE TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent
=== RUN   TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== PAUSE TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== RUN   TestAccBedrockAgentAgentActionGroup_update
=== PAUSE TestAccBedrockAgentAgentActionGroup_update
=== RUN   TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== PAUSE TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== RUN   TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== PAUSE TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== RUN   TestAccBedrockAgentAgentAlias_basic
=== PAUSE TestAccBedrockAgentAgentAlias_basic
=== RUN   TestAccBedrockAgentAgentAlias_disappears
=== PAUSE TestAccBedrockAgentAgentAlias_disappears
=== RUN   TestAccBedrockAgentAgentAlias_update
=== PAUSE TestAccBedrockAgentAgentAlias_update
=== RUN   TestAccBedrockAgentAgentAlias_routingUpdate
=== PAUSE TestAccBedrockAgentAgentAlias_routingUpdate
=== RUN   TestAccBedrockAgentAgentAlias_tags
=== PAUSE TestAccBedrockAgentAgentAlias_tags
=== RUN   TestAccBedrockAgentAgentAlias_provisionedThroughput
    agent_alias_test.go:227: Bedrock Provisioned Model Throughput for Antropic Claude 2 has a minimum 1 month commitment and costs > $45K/month
--- SKIP: TestAccBedrockAgentAgentAlias_provisionedThroughput (0.00s)
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic
    agent_knowledge_base_association_test.go:26: File  not found on PATH, skipping test: exec: "psql": executable file not found in $PATH
--- SKIP: TestAccBedrockAgentAgentKnowledgeBaseAssociation_basic (0.00s)
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_update
    agent_knowledge_base_association_test.go:76: File  not found on PATH, skipping test: exec: "psql": executable file not found in $PATH
--- SKIP: TestAccBedrockAgentAgentKnowledgeBaseAssociation_update (0.00s)
=== RUN   TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears
    agent_knowledge_base_association_test.go:134: File  not found on PATH, skipping test: exec: "psql": executable file not found in $PATH
--- SKIP: TestAccBedrockAgentAgentKnowledgeBaseAssociation_disappears (0.00s)
=== RUN   TestAccBedrockAgentAgent_basic
=== PAUSE TestAccBedrockAgentAgent_basic
=== RUN   TestAccBedrockAgentAgent_full
=== PAUSE TestAccBedrockAgentAgent_full
=== RUN   TestAccBedrockAgentAgent_singlePrompt
=== PAUSE TestAccBedrockAgentAgent_singlePrompt
=== RUN   TestAccBedrockAgentAgent_singlePromptUpdate
=== PAUSE TestAccBedrockAgentAgent_singlePromptUpdate
=== RUN   TestAccBedrockAgentAgent_addPrompt
=== PAUSE TestAccBedrockAgentAgent_addPrompt
=== RUN   TestAccBedrockAgentAgent_guardrail
=== PAUSE TestAccBedrockAgentAgent_guardrail
=== RUN   TestAccBedrockAgentAgent_update
=== PAUSE TestAccBedrockAgentAgent_update
=== RUN   TestAccBedrockAgentAgent_tags
=== PAUSE TestAccBedrockAgentAgent_tags
=== RUN   TestAccBedrockAgentAgent_kms
=== PAUSE TestAccBedrockAgentAgent_kms
=== CONT  TestAccBedrockAgentAgentActionGroup_basic
=== CONT  TestAccBedrockAgentAgentAlias_tags
=== CONT  TestAccBedrockAgentAgent_kms
=== CONT  TestAccBedrockAgentAgent_tags
=== CONT  TestAccBedrockAgentAgent_update
=== CONT  TestAccBedrockAgentAgent_guardrail
=== CONT  TestAccBedrockAgentAgent_addPrompt
=== CONT  TestAccBedrockAgentAgent_singlePromptUpdate
=== CONT  TestAccBedrockAgentAgent_singlePrompt
=== CONT  TestAccBedrockAgentAgent_full
=== CONT  TestAccBedrockAgentAgent_basic
=== CONT  TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl
=== CONT  TestAccBedrockAgentAgentAlias_routingUpdate
=== CONT  TestAccBedrockAgentAgentAlias_update
=== CONT  TestAccBedrockAgentAgentAlias_disappears
=== CONT  TestAccBedrockAgentAgentAlias_basic
=== CONT  TestAccBedrockAgentAgentActionGroup_update
=== CONT  TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions
=== CONT  TestAccBedrockAgentAgentActionGroup_APISchema_s3
=== CONT  TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent
--- PASS: TestAccBedrockAgentAgent_basic (115.57s)
--- PASS: TestAccBedrockAgentAgentAlias_disappears (116.28s)
--- PASS: TestAccBedrockAgentAgent_full (117.58s)
--- PASS: TestAccBedrockAgentAgent_singlePrompt (127.22s)
--- PASS: TestAccBedrockAgentAgentActionGroup_FunctionSchema_memberFunctions (128.47s)
--- PASS: TestAccBedrockAgentAgentActionGroup_basic (129.47s)
--- PASS: TestAccBedrockAgentAgentAlias_basic (131.74s)
--- PASS: TestAccBedrockAgentAgentActionGroup_ActionGroupExecutor_customControl (151.14s)
--- PASS: TestAccBedrockAgentAgentActionGroup_APISchema_s3 (151.28s)
--- PASS: TestAccBedrockAgentAgent_singlePromptUpdate (161.87s)
--- PASS: TestAccBedrockAgentAgent_kms (164.07s)
--- PASS: TestAccBedrockAgentAgentActionGroup_upgradeToPrepareAgent (164.38s)
--- PASS: TestAccBedrockAgentAgentAlias_update (172.22s)
--- PASS: TestAccBedrockAgentAgentAlias_routingUpdate (182.45s)
--- PASS: TestAccBedrockAgentAgentActionGroup_update (190.69s)
--- PASS: TestAccBedrockAgentAgent_tags (192.68s)
--- PASS: TestAccBedrockAgentAgent_update (194.83s)
--- PASS: TestAccBedrockAgentAgentAlias_tags (199.70s)
--- PASS: TestAccBedrockAgentAgent_guardrail (213.78s)
--- PASS: TestAccBedrockAgentAgent_addPrompt (225.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       225.700s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

% make testacc PKG=bedrockagent TESTS=TestAccBedrockAgentAgent_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgent_'  -timeout 360m
2024/12/04 09:23:30 Initializing Terraform AWS Provider...

--- PASS: TestAccBedrockAgentAgent_basic (25.80s)
--- PASS: TestAccBedrockAgentAgent_singlePrompt (26.11s)
--- PASS: TestAccBedrockAgentAgent_full (26.67s)
--- PASS: TestAccBedrockAgentAgent_singlePromptUpdate (37.27s)
--- PASS: TestAccBedrockAgentAgent_kms (42.99s)
--- PASS: TestAccBedrockAgentAgent_tags (45.47s)
--- PASS: TestAccBedrockAgentAgent_update (58.31s)
--- PASS: TestAccBedrockAgentAgent_addPrompt (62.33s)
--- PASS: TestAccBedrockAgentAgent_guardrail (65.07s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       71.654s

[jar-b]

Thanks for your contribution, @stefanfreitag! 🚀

[github-actions]

This functionality has been released in v5.80.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.