feat: allow notebook-al2-v3 as platform_identifier

[stefanfreitag]

Description

Change the plan-time validation to allow the platform identifier notebook-al2-v3 (Amazon Linux 2 v3) for the resource aws_sagemaker_notebook_instance.

Relations

Closes #40478

References

• Supported notebook instances mentioning the new type.
• CloudFormation mentioning the pattern for allowed values.

Output from Acceptance Testing

❯ make testacc TESTS=TestAccSageMakerNotebookInstance_Platform_identifier PKG=sagemaker
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sagemaker/... -v -count 1 -parallel 3 -run='TestAccSageMakerNotebookInstance_Platform_identifier'  -timeout 360m
2024/12/07 22:25:42 Initializing Terraform AWS Provider...
=== RUN   TestAccSageMakerNotebookInstance_Platform_identifier
=== PAUSE TestAccSageMakerNotebookInstance_Platform_identifier
=== CONT  TestAccSageMakerNotebookInstance_Platform_identifier

--- PASS: TestAccSageMakerNotebookInstance_Platform_identifier (1163.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  1163.999s

I was also trying to run

make testacc TESTS=TestAccSageMakerNotebookInstance PKG=sagemaker

but it failed with

    notebook_instance_test.go:645: Step 1/4 error: Error running apply: exit status 1
        
        Error: creating SageMaker Notebook Instance: operation error SageMaker: CreateNotebookInstance, https response error StatusCode: 400, RequestID: b52ab698-e767-4931-bf5a-f6c4bbf4e13a, ResourceLimitExceeded: The account-level service limit 'ml.inf1.xlarge for notebook instance usage' is 0 Instances, with current utilization of 0 Instances and a request delta of 1 Instances. Please use AWS Service Quotas to request an increase for this quota. If AWS Service Quotas is not available, contact AWS support to request an increase for this quota.
        
          with aws_sagemaker_notebook_instance.test,
          on terraform_plugin_test.tf line 29, in resource "aws_sagemaker_notebook_instance" "test":
          29: resource "aws_sagemaker_notebook_instance" "test" {

Will request an upgrade of the limits, so that this one can also get executed.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

[ewbankkit]

@stefanfreitag Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.81.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.