Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/rds_cluster: fix wait error when modifying allocated_storage #40601

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Dec 17, 2024

Description

Modifying allocated_storage could produce the following error:

│ Error: waiting for RDS Cluster (random-name) update: unexpected state 'scaling-storage', wanted target 'available'. last error: %!s(<nil>)

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSCluster_allocatedStorage_\|TestAccRDSCluster_basic\|TestAccRDSCluster_disappears' PKG=rds

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_allocatedStorage_\|TestAccRDSCluster_basic\|TestAccRDSCluster_disappears -timeout 360m
2024/12/17 12:27:13 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== RUN   TestAccRDSCluster_allocatedStorage_io1
=== PAUSE TestAccRDSCluster_allocatedStorage_io1
=== RUN   TestAccRDSCluster_allocatedStorage_gp3
=== PAUSE TestAccRDSCluster_allocatedStorage_gp3
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_allocatedStorage_io1
=== CONT  TestAccRDSCluster_disappears
=== CONT  TestAccRDSCluster_allocatedStorage_gp3
--- PASS: TestAccRDSCluster_disappears (103.87s)
--- PASS: TestAccRDSCluster_basic (115.78s)
--- PASS: TestAccRDSCluster_allocatedStorage_io1 (1181.23s)
--- PASS: TestAccRDSCluster_allocatedStorage_gp3 (1316.35s)
PASS

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 17, 2024
@johnsonaj johnsonaj added the bug Addresses a defect in current functionality. label Dec 17, 2024
@johnsonaj johnsonaj marked this pull request as ready for review December 17, 2024 19:52
@johnsonaj johnsonaj requested a review from a team as a code owner December 17, 2024 19:52
@johnsonaj johnsonaj enabled auto-merge December 17, 2024 21:26
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

> make testacc TESTARGS='-run=TestAccRDSCluster_allocatedStorage_\|TestAccRDSCluster_basic\|TestAccRDSCluster_disappears' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCluster_allocatedStorage_\|TestAccRDSCluster_basic\|TestAccRDSCluster_disappears -timeout 360m
2024/12/17 13:28:28 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_disappears
=== PAUSE TestAccRDSCluster_disappears
=== RUN   TestAccRDSCluster_allocatedStorage_io1
=== PAUSE TestAccRDSCluster_allocatedStorage_io1
=== RUN   TestAccRDSCluster_allocatedStorage_gp3
=== PAUSE TestAccRDSCluster_allocatedStorage_gp3
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_allocatedStorage_io1
=== CONT  TestAccRDSCluster_allocatedStorage_gp3
=== CONT  TestAccRDSCluster_disappears
--- PASS: TestAccRDSCluster_disappears (103.39s)
--- PASS: TestAccRDSCluster_basic (105.35s)
--- PASS: TestAccRDSCluster_allocatedStorage_io1 (1423.55s)
--- PASS: TestAccRDSCluster_allocatedStorage_gp3 (1912.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1919.058s

@johnsonaj johnsonaj merged commit 4b38a12 into main Dec 17, 2024
59 checks passed
@johnsonaj johnsonaj deleted the b-rds-allocated_storage_modify branch December 17, 2024 22:02
@github-actions github-actions bot added this to the v5.82.0 milestone Dec 17, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Dec 17, 2024
Copy link

This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 19, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants