Add attributes to the aws_ec2_instance_type data source

[bakeemawaytoys]

Description

Added the following attributes to the aws_ec2_instance_type data source to bring it up-to-date with the EC2 API. I tried to follow the data source's established conventions with respect to nullability, naming, and flattening attributes that are nested in the AWS API. One thing I'm not clear on is which type to use for attributes that are collections of strings. I went with sets instead of lists because ordering doesn't make sense nor is it explicitly guaranteed by the AWS API. Existing attributes tended be lists. I can change them to lists if consistency is more important.

As I was updating the documentation, I adjusted some of the descriptions of existing attributes to clarify their data types and/or their expected values. My intent is to reduce the need to cross-reference the data source's documentation with the AWS API documentation in order to understand the attribute values.

• bandwidth_weightings
• boot_modes
• default_network_card_index
• efa_maximum_interfaces
• ena_srd_supported
• inference_accelerators.#.memory_size
• media_accelerators.#.count
• media_accelerators.#.manufacturer
• media_accelerators.#.memory_size
• media_accelerators.#.name
• network_cards.#.baseline_bandwidth
• network_cards.#.index
• network_cards.#.maximum_interfaces
• network_cards.#.performance
• network_cards.#.peak_bandwidth
• neuron_devices.#.core_count
• neuron_devices.#.core_version
• neuron_devices.#.count
• neuron_devices.#.memory_size
• neuron_devices.#.name
• nitro_enclaves_support
• nitro_tpm_support
• nitro_tpm_supported_versions
• phc_support
• supported_cpu_features
• total_inference_memory
• total_media_memory
• total_neuron_device_memory

Relations

Closes #35640

References

AWS CLI documentation for the describe-instance-type command
AWS EC2 API documentation for the DescribeInstanceTypes action

Output from Acceptance Testing

% make testacc TESTS=TestAccEC2InstanceTypeDataSource  PKG=ec2 

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypeDataSource'  -timeout 360m
2025/01/04 11:32:42 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2InstanceTypeDataSource_basic
=== PAUSE TestAccEC2InstanceTypeDataSource_basic
=== RUN   TestAccEC2InstanceTypeDataSource_metal
=== PAUSE TestAccEC2InstanceTypeDataSource_metal
=== RUN   TestAccEC2InstanceTypeDataSource_gpu
=== PAUSE TestAccEC2InstanceTypeDataSource_gpu
=== RUN   TestAccEC2InstanceTypeDataSource_fpga
=== PAUSE TestAccEC2InstanceTypeDataSource_fpga
=== RUN   TestAccEC2InstanceTypeDataSource_neuron
=== PAUSE TestAccEC2InstanceTypeDataSource_neuron
=== RUN   TestAccEC2InstanceTypeDataSource_media_accelerator
=== PAUSE TestAccEC2InstanceTypeDataSource_media_accelerator
=== CONT  TestAccEC2InstanceTypeDataSource_basic
=== CONT  TestAccEC2InstanceTypeDataSource_fpga
=== CONT  TestAccEC2InstanceTypeDataSource_media_accelerator
=== CONT  TestAccEC2InstanceTypeDataSource_neuron
=== CONT  TestAccEC2InstanceTypeDataSource_gpu
=== CONT  TestAccEC2InstanceTypeDataSource_metal
--- PASS: TestAccEC2InstanceTypeDataSource_basic (7.70s)
--- PASS: TestAccEC2InstanceTypeDataSource_media_accelerator (7.71s)
--- PASS: TestAccEC2InstanceTypeDataSource_fpga (7.73s)
--- PASS: TestAccEC2InstanceTypeDataSource_neuron (7.77s)
--- PASS: TestAccEC2InstanceTypeDataSource_metal (7.77s)
--- PASS: TestAccEC2InstanceTypeDataSource_gpu (7.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        11.975s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2InstanceTypeDataSource_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2InstanceTypeDataSource_ -timeout 360m -vet=off
2025/01/12 17:00:29 Initializing Terraform AWS Provider...
=== RUN   TestAccEC2InstanceTypeDataSource_basic
=== PAUSE TestAccEC2InstanceTypeDataSource_basic
=== RUN   TestAccEC2InstanceTypeDataSource_metal
=== PAUSE TestAccEC2InstanceTypeDataSource_metal
=== RUN   TestAccEC2InstanceTypeDataSource_gpu
=== PAUSE TestAccEC2InstanceTypeDataSource_gpu
=== RUN   TestAccEC2InstanceTypeDataSource_fpga
=== PAUSE TestAccEC2InstanceTypeDataSource_fpga
=== RUN   TestAccEC2InstanceTypeDataSource_neuron
=== PAUSE TestAccEC2InstanceTypeDataSource_neuron
=== RUN   TestAccEC2InstanceTypeDataSource_media_accelerator
=== PAUSE TestAccEC2InstanceTypeDataSource_media_accelerator
=== CONT  TestAccEC2InstanceTypeDataSource_basic
=== CONT  TestAccEC2InstanceTypeDataSource_fpga
=== CONT  TestAccEC2InstanceTypeDataSource_media_accelerator
=== CONT  TestAccEC2InstanceTypeDataSource_neuron
=== CONT  TestAccEC2InstanceTypeDataSource_gpu
=== CONT  TestAccEC2InstanceTypeDataSource_metal
--- PASS: TestAccEC2InstanceTypeDataSource_media_accelerator (10.55s)
--- PASS: TestAccEC2InstanceTypeDataSource_metal (10.56s)
--- PASS: TestAccEC2InstanceTypeDataSource_gpu (10.57s)
--- PASS: TestAccEC2InstanceTypeDataSource_fpga (10.57s)
--- PASS: TestAccEC2InstanceTypeDataSource_basic (10.57s)
--- PASS: TestAccEC2InstanceTypeDataSource_neuron (10.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	16.631s

[jar-b]

LGTM 🚀

[ewbankkit]

@bakeemawaytoys Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.84.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!