Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetOpenIdTokenForDeveloperIdentity ephemeral resource #40763

Merged
merged 9 commits into from
Jan 8, 2025
Merged

GetOpenIdTokenForDeveloperIdentity ephemeral resource #40763

merged 9 commits into from
Jan 8, 2025
+268 −0

Conversation

danquack
Copy link
Contributor

@danquack danquack commented Jan 3, 2025 •
edited
Loading

Description

Creates an ephemeral resource for GetOpenIdTokenForDeveloperIdentity.

Relations

Closes #29673

References

Output from Acceptance Testing

% make testacc TESTS=TestAccCognitoIdentityOpenIDTokenForDeveloperIdentity PKG=cognitoidentity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cognitoidentity/... -v -count 1 -parallel 20 -run='TestAccCognitoIdentityOpenIDTokenForDeveloperIdentity'  -timeout 360m
2025/01/03 12:03:48 Initializing Terraform AWS Provider...
=== RUN   TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic
=== PAUSE TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic
=== CONT  TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic
--- PASS: TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic (14.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity    18.232s

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2025
@danquack danquack force-pushed the 29673/cognito-identity branch from 1443c16 to 7e894a9 Compare January 3, 2025 16:32
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 3, 2025
@danquack danquack force-pushed the 29673/cognito-identity branch from 7e894a9 to 21ec0b8 Compare January 3, 2025 16:37
@danquack danquack marked this pull request as ready for review January 3, 2025 16:38
@danquack danquack requested a review from a team as a code owner January 3, 2025 16:38
@danquack danquack force-pushed the 29673/cognito-identity branch from a487994 to 97f870e Compare January 3, 2025 17:05
@ewbankkit ewbankkit added the new-ephemeral-resource Introduces a new ephemeral resource. label Jan 6, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 8, 2025
@ewbankkit ewbankkit self-assigned this Jan 8, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 8, 2025
ewbankkit
ewbankkit previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_' PKG=cognitoidentity
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cognitoidentity/... -v -count 1 -parallel 20  -run=TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_ -timeout 360m
2025/01/08 10:52:27 Initializing Terraform AWS Provider...
=== RUN   TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic
=== PAUSE TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic
=== CONT  TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic
--- PASS: TestAccCognitoIdentityOpenIDTokenForDeveloperIdentityEphemeral_basic (12.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	17.222s

@ewbankkit @jar-b
Update website/docs/ephemeral-resources/cognito_identity_openid_token…
e2c549a 
…_for_developer_identity.markdown

Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
jar-b
jar-b approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💨

@ewbankkit
Copy link
Contributor

@danquack Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0568ae8 into hashicorp:main Jan 8, 2025
45 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Jan 8, 2025
@bschaatsbergen
Copy link
Member

Great work on this @danquack!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
@clementdenis clementdenis mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

@jar-b jar-b jar-b approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-ephemeral-resource Introduces a new ephemeral resource. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.83.0
Development

Successfully merging this pull request may close these issues.

[New]: Resource for GetOpenIdTokenForDeveloperIdentity
4 participants
@danquack @ewbankkit @bschaatsbergen @jar-b