-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix S3 on Outposts read error for aws_datasync_location_s3 #40929
fix: Fix S3 on Outposts read error for aws_datasync_location_s3 #40929
Conversation
Community NoteVoting for Prioritization
For Submitters
|
4c48873
to
9c1778a
Compare
9c1778a
to
b5dbce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDataSyncLocationS3_' PKG=datasync ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/datasync/... -v -count 1 -parallel 3 -run=TestAccDataSyncLocationS3_ -timeout 360m -vet=off
2025/01/15 14:32:38 Initializing Terraform AWS Provider...
=== RUN TestAccDataSyncLocationS3_basic
=== PAUSE TestAccDataSyncLocationS3_basic
=== RUN TestAccDataSyncLocationS3_storageClass
=== PAUSE TestAccDataSyncLocationS3_storageClass
=== RUN TestAccDataSyncLocationS3_disappears
=== PAUSE TestAccDataSyncLocationS3_disappears
=== RUN TestAccDataSyncLocationS3_tags
=== PAUSE TestAccDataSyncLocationS3_tags
=== CONT TestAccDataSyncLocationS3_basic
=== CONT TestAccDataSyncLocationS3_disappears
=== CONT TestAccDataSyncLocationS3_tags
--- PASS: TestAccDataSyncLocationS3_disappears (25.30s)
=== CONT TestAccDataSyncLocationS3_storageClass
--- PASS: TestAccDataSyncLocationS3_basic (27.13s)
--- PASS: TestAccDataSyncLocationS3_storageClass (16.22s)
--- PASS: TestAccDataSyncLocationS3_tags (48.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/datasync 53.984s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.84.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR is to fix a global ID parse error when reading an S3 location that is on AWS Outposts.
Note that due to the difficulty in setting up Outposts in a unit test scenario, I am unable to unit test the resource fully.
Relations
Closes #40693
References
Referred to CreateLocationS3 for specs and wordings.
Output from Acceptance Testing