Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support resource import for aws_vpc_endpoint_security_group_association #41042

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jan 23, 2025

Description

This PR is to add support for importing aws_vpc_endpoint_security_group_association resources.

Relations

Closes #41039

References

n/a

Output from Acceptance Testing

$ make testacc TESTS=TestAccVPCEndpointSecurityGroupAssociation_ PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCEndpointSecurityGroupAssociation_'  -timeout 360m -vet=off
2025/01/22 23:45:03 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_basic
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_basic
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_multiple
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_disappears
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_basic (48.76s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (85.37s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_disappears (85.96s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_multiple (98.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        98.877s

$

@acwwat acwwat requested a review from a team as a code owner January 23, 2025 04:49
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jan 23, 2025
@acwwat acwwat force-pushed the f-aws_vpc_endpoint_security_group_association-add_import branch from babd419 to 53097ac Compare January 23, 2025 04:50
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 23, 2025
@ewbankkit ewbankkit self-assigned this Jan 23, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 23, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCEndpointSecurityGroupAssociation_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCEndpointSecurityGroupAssociation_ -timeout 360m -vet=off
2025/01/23 07:48:25 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_basic
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_disappears
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_multiple
=== RUN   TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_basic
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_multiple
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_disappears (74.18s)
=== CONT  TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_multiple (98.37s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_basic (104.07s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (70.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	149.957s

@ewbankkit ewbankkit merged commit 4902131 into hashicorp:main Jan 23, 2025
49 checks passed
@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added this to the v5.85.0 milestone Jan 23, 2025
@acwwat acwwat deleted the f-aws_vpc_endpoint_security_group_association-add_import branch January 24, 2025 01:56
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: import support for aws_vpc_endpoint_security_group_association
2 participants