-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support resource import for aws_vpc_endpoint_security_group_association #41042
feat: Support resource import for aws_vpc_endpoint_security_group_association #41042
Conversation
Community NoteVoting for Prioritization
For Submitters
|
babd419
to
53097ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCEndpointSecurityGroupAssociation_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCEndpointSecurityGroupAssociation_ -timeout 360m -vet=off
2025/01/23 07:48:25 Initializing Terraform AWS Provider...
=== RUN TestAccVPCEndpointSecurityGroupAssociation_basic
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_basic
=== RUN TestAccVPCEndpointSecurityGroupAssociation_disappears
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_disappears
=== RUN TestAccVPCEndpointSecurityGroupAssociation_multiple
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_multiple
=== RUN TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== PAUSE TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
=== CONT TestAccVPCEndpointSecurityGroupAssociation_basic
=== CONT TestAccVPCEndpointSecurityGroupAssociation_multiple
=== CONT TestAccVPCEndpointSecurityGroupAssociation_disappears
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_disappears (74.18s)
=== CONT TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_multiple (98.37s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_basic (104.07s)
--- PASS: TestAccVPCEndpointSecurityGroupAssociation_replaceDefaultAssociation (70.08s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 149.957s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR is to add support for importing
aws_vpc_endpoint_security_group_association
resources.Relations
Closes #41039
References
n/a
Output from Acceptance Testing