Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new ephemeral resource] aws_secretsmanager_random_password #41106

Merged
merged 7 commits into from
Jan 28, 2025
Merged

[new ephemeral resource] aws_secretsmanager_random_password #41106

merged 7 commits into from
Jan 28, 2025
+212 −0

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jan 27, 2025 •
edited
Loading

Description

Adds new ephemeral resource for Secrets Manager Random Password

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSecretsManagerRandomPasswordEphemeral_basic' PKG=secretsmanager

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/secretsmanager/... -v -count 1 -parallel 20  -run=TestAccSecretsManagerRandomPasswordEphemeral_basic -timeout 360m -vet=off
2025/01/27 13:45:57 Initializing Terraform AWS Provider...
=== RUN   TestAccSecretsManagerRandomPasswordEphemeral_basic
=== PAUSE TestAccSecretsManagerRandomPasswordEphemeral_basic
=== CONT  TestAccSecretsManagerRandomPasswordEphemeral_basic
--- PASS: TestAccSecretsManagerRandomPasswordEphemeral_basic (10.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	17.129s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jan 27, 2025
@johnsonaj johnsonaj added the new-ephemeral-resource Introduces a new ephemeral resource. label Jan 27, 2025
@johnsonaj johnsonaj marked this pull request as ready for review January 27, 2025 20:02
@johnsonaj johnsonaj requested a review from a team as a code owner January 27, 2025 20:02
johnsonaj and others added 2 commits January 28, 2025 09:05
@johnsonaj @jar-b
Apply suggestions from code review
1e34d45 
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
@johnsonaj @jar-b
Update website/docs/ephemeral-resources/secretsmanager_random_passwor…
0c0eea8 
…d.html.markdown

Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
@johnsonaj johnsonaj requested a review from jar-b January 28, 2025 15:43
jar-b
jar-b approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=secretsmanager TESTS=TestAccSecretsManagerRandomPasswordEphemeral
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/secretsmanager/... -v -count 1 -parallel 20 -run='TestAccSecretsManagerRandomPasswordEphemeral'  -timeout 360m -vet=off
2025/01/28 11:09:13 Initializing Terraform AWS Provider...
=== RUN   TestAccSecretsManagerRandomPasswordEphemeral_basic
=== PAUSE TestAccSecretsManagerRandomPasswordEphemeral_basic
=== CONT  TestAccSecretsManagerRandomPasswordEphemeral_basic
--- PASS: TestAccSecretsManagerRandomPasswordEphemeral_basic (11.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager     17.935s

@johnsonaj johnsonaj merged commit 5011706 into main Jan 28, 2025
44 checks passed
@johnsonaj johnsonaj deleted the f-ephemeral_random_password branch January 28, 2025 16:24
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 28, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Jan 28, 2025
Update CHANGELOG.md for #41106
a61803f
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-ephemeral-resource Introduces a new ephemeral resource. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.85.0
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsonaj @jar-b