Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing rate limit in aws_wafregional_rate_based_rule does not result in an update #5355

Closed
splieth opened this issue Jul 26, 2018 · 4 comments
Labels
bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service.
Milestone

Comments

@splieth
Copy link
Contributor

splieth commented Jul 26, 2018

When I want to update the rate_limit in a aws_wafregional_rate_based_rule resource, terraform plan actually says that there will be an update and that the resource changed. Unfortunately, the update is not performed due to the implementation of the resource. Therefore, the limit remains the same.

Terraform Version

Terraform v0.11.7

Affected Resource(s)

  • aws_wafregional_rate_based_rule

Terraform Configuration Files

resource "aws_wafregional_rate_based_rule" "some_rule" {
  name = "some_metric"
  metric_name = "some_metric"
  rate_key = "IP"
  rate_limit = 2000
}

Expected Behavior

Rate limit should have been updated.

Actual Behavior

Rate limit is not updated.

Steps to Reproduce

  1. terraform apply
  2. Change rate limit:
resource "aws_wafregional_rate_based_rule" "some_rule" {
  name = "some_metric"
  metric_name = "some_metric"
  rate_key = "IP"
  rate_limit = 2001
}
  1. terraform apply
@bflad bflad added bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service. labels Jul 27, 2018
@bflad bflad added this to the v1.30.0 milestone Jul 27, 2018
@bflad
Copy link
Contributor

bflad commented Jul 27, 2018

The fix for this has been merged into master and will release with version 1.30.0 of the AWS provider

@bflad bflad closed this as completed Jul 27, 2018
@bflad
Copy link
Contributor

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@peterschmidt85
Copy link

I experienced the same issue with the 2.x version of the AWS provider. Anyone else?

@ghost
Copy link

ghost commented Feb 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/waf Issues and PRs that pertain to the waf service.
Projects
None yet
Development

No branches or pull requests

3 participants