Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed "UpdatePolicy" Attribute in resource "aws_autoscaling_group" #5361

Closed
ozbillwang opened this issue Jul 27, 2018 · 4 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. upstream Addresses functionality related to the cloud provider.

Comments

@ozbillwang
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Missed UpdatePolicy Attribute in resource aws_autoscaling_group

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatepolicy.html#cfn-attributes-updatepolicy-replacingupdate

New or Affected Resource(s)

  • aws_autoscaling_group

Potential Terraform Configuration

"UpdatePolicy" : {
  "AutoScalingReplacingUpdate" : {
    "WillReplace" : Boolean
  }
}

"UpdatePolicy" : {
  "AutoScalingRollingUpdate" : {
    "MaxBatchSize" : Integer,
    "MinInstancesInService" : Integer,
    "MinSuccessfulInstancesPercent" : Integer
    "PauseTime" : String,
    "SuspendProcesses" : [ List of processes ],
    "WaitOnResourceSignals" : Boolean
  }
}

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-updatepolicy.html#cfn-attributes-updatepolicy-replacingupdate

  • #0000
@ozbillwang
Copy link
Author

I have the feeling, that this issue has been identified before, so someone worked around it with a CFN template.

#4577

#4432

#5273

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. upstream Addresses functionality related to the cloud provider. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Aug 1, 2018
@bflad
Copy link
Contributor

bflad commented Aug 1, 2018

Hi @ozbillwang 👋 Can you point to the API reference documentation for which
API actions/parameters would handle this? I feel like the last time I looked this up, it seemed like this was something only built into CloudFormation and not part of the API, but maybe I missed it or the situation has changed.

@ozbillwang
Copy link
Author

ozbillwang commented Aug 2, 2018

@bflad

Thanks to point this. I have confirmed with AWS via support ticket. This feature is only in Cloudformation, not in API currently, a ticket had been raised to API team to add this feature, but not sure when it can be implemented.

In fact, this UpdatePolicy calls API to adjust desired capacity, so we have to use Cloudformation template with this feature in Terraform currently, otherwise, frequently adjust desired capacity (for example, increase 2, wait, decrease 2, until all instances to be replaced with new setting).

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

No branches or pull requests

2 participants