Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_s3_bucket_object: Remove ALL leading '/'s from key when destroying #7583

Closed
ewbankkit opened this issue Feb 15, 2019 · 4 comments · Fixed by #7584
Closed

r/aws_s3_bucket_object: Remove ALL leading '/'s from key when destroying #7583

ewbankkit opened this issue Feb 15, 2019 · 4 comments · Fixed by #7584
Labels
bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service.

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform effectively ignores ALL leading / characters at the start of an S3 bucket object's key value when creating. This must be taken into account when destroying the resource (equivalent to deleting all object versions).
I found this while fixing #7362.
Related:

@nywilken nywilken added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3 Issues and PRs that pertain to the s3 service. labels Feb 15, 2019
@bflad bflad removed the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Feb 16, 2019
@ewbankkit
Copy link
Contributor Author

I've also noticed that multiple /s inside or at the end of a key name are compressed to a single /, so that first/second//third/// and first/second/third are equivalent.
I'll update the PR.

@aeschright aeschright added the needs-triage Waiting for first response or review from a maintainer. label Jun 24, 2019
@aeschright
Copy link
Contributor

Hi @ewbankkit! Is #7584 the only PR left that's needed to resolve this issue?

@aeschright aeschright added waiting-response Maintainers are waiting on response from community or contributor. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 22, 2019
@ewbankkit
Copy link
Contributor Author

@aeschright Correct. #7584 will close this issue. Thanks.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 23, 2019
@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/s3 Issues and PRs that pertain to the s3 service.
Projects
None yet
4 participants