Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ecs_service: enable_ecs_managed_tags doesn't apply on existing services #7973

Closed
ericdahl opened this issue Mar 17, 2019 · 4 comments · Fixed by #7983
Closed

aws_ecs_service: enable_ecs_managed_tags doesn't apply on existing services #7973

ericdahl opened this issue Mar 17, 2019 · 4 comments · Fixed by #7983
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service.
Milestone

Comments

@ericdahl
Copy link

ericdahl commented Mar 17, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.11.2

  • provider.aws v2.2.0
  • provider.template v2.1.0

Affected Resource(s)

  • aws_ecs_service

Terraform Configuration Files

resource "aws_ecs_service" "httpbin" {
  cluster         = "tf-cluster"
  name            = "tf-cluster-httpbin"
  task_definition = "${aws_ecs_task_definition.httpbin.arn}"
  desired_count   = "1"

  lifecycle {
    ignore_changes = ["desired_count"]
  }

//  enable_ecs_managed_tags = true
  propagate_tags = "SERVICE"

  tags {
    Name = "httpbin"
  }
}

Debug Output

Panic Output

Expected Behavior

When I toggle on

enable_ecs_managed_tags = true

I expect that this feature is enabled and that this returns true:

aws ecs describe-services --cluster tf-cluster --services tf-cluster-httpbin | jq '.services[].enableECSManagedTags'
false

Actual Behavior

Feature is not toggled on and every Terraform Plan reports that it will attempt to re-set it. It appears that this is an immutable property, as the UpdateService API does not support it (only CreateService does)

This suggests it ought to have the ForceNew flag enabled based on other similar properties.

Steps to Reproduce

  1. Create service with enable_ecs_managed_tags turned off
  2. Update service to enable enable_ecs_managed_tags

Important Factoids

References

#6544

  • #0000
@bflad bflad added bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. labels Mar 17, 2019
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Mar 6, 2021
@roman-parkhunovskyi
Copy link

I can confirm the issue is still reproducible with the latest versions:

Terraform v0.14.9
+ provider registry.terraform.io/hashicorp/aws v3.34.0
+ provider registry.terraform.io/hashicorp/template v2.2.0

@ghost ghost removed the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Apr 1, 2021
@github-actions github-actions bot added this to the v3.67.0 milestone Nov 24, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants