Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS App Mesh GA additions #8102

Closed
ewbankkit opened this issue Mar 27, 2019 · 7 comments · Fixed by #8119
Closed

AWS App Mesh GA additions #8102

ewbankkit opened this issue Mar 27, 2019 · 7 comments · Fixed by #8119
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Need to diff the AWS App Mesh GA changes and support additions.
Resource tagging is a separate issue: #8101.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 27, 2019
@ewbankkit
Copy link
Contributor Author

@ewbankkit
Copy link
Contributor Author

aws_appmesh_mesh

Add support for egress filter rules:

resource "aws_appmesh_mesh" "simple" {
  name = "simpleapp"

  spec {
    egress_filter {
      type = "ALLOW_ALL"
    }
  }
}

aws_appmesh_route

Add support for TCP routing:

resource "aws_appmesh_route" "serviceb" {
  name                = "serviceB-route"
  mesh_name           = "${aws_appmesh_mesh.simple.id}"
  virtual_router_name = "${aws_appmesh_virtual_router.serviceb.name}"

  spec {
    tcp_route {
      action {
        weighted_target {
          virtual_node = "${aws_appmesh_virtual_node.serviceb1.name}"
          weight       = 100
        }
      }
    }
  }
}

aws_appmesh_virtual_node

Add support for access logging:

resource "aws_appmesh_virtual_node" "serviceb1" {
  name                = "serviceBv1"
  mesh_name           = "${aws_appmesh_mesh.simple.id}"

  spec {
    logging {
      access_log {
        file {
          path = "/dev/stdout"
        }
      }
    }
  }
}

@ewbankkit
Copy link
Contributor Author

@bcelenza Have I captured all the GA changes here (tagging is covered in a separate issue, #8101)?

@bcelenza
Copy link
Contributor

@ewbankkit Yes, you've captured them well. Looks good to me. :)

@bflad bflad added the service/appmesh Issues and PRs that pertain to the appmesh service. label Apr 10, 2019
@bflad bflad added this to the v2.6.0 milestone Apr 10, 2019
@bflad
Copy link
Contributor

bflad commented Apr 10, 2019

These enhancements has been merged and will release with version 2.6.0 of the Terraform AWS Provider later today. 👍

@bflad
Copy link
Contributor

bflad commented Apr 11, 2019

This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants