Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blackhole Attribute to aws_ec2_transit_gateway_route #9046

Closed
stockhausenj opened this issue Jun 19, 2019 · 4 comments · Fixed by #9224
Closed

Add blackhole Attribute to aws_ec2_transit_gateway_route #9046

stockhausenj opened this issue Jun 19, 2019 · 4 comments · Fixed by #9224
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@stockhausenj
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

With the AWS API it's possible to declare a transit gateway route table route as a blackhole. Which means that traffic matching the route will be dropped.
API: https://docs.aws.amazon.com/cli/latest/reference/ec2/create-transit-gateway-route.html
If a route is a blackhole then the attribute transit_gateway_attachment_id is ignored.

New or Affected Resource(s)

  • aws_ec2_transit_gateway_route

Potential Terraform Configuration

resource "aws_ec2_transit_gateway_route" "example" {
  destination_cidr_block              = "10.0.0.0/8"
  blackhole                                   = true
  transit_gateway_route_table_id = "${aws_ec2_transit_gateway.example.association_default_route_table_id}"
}

References

  • #0000
@stockhausenj stockhausenj added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 19, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 19, 2019
@kellersyf
Copy link

I'm really surprised this isn't here already. Implementation should just be adding the blackhole flag and not setting the transit-gateway-attachment-id field.

Here's the AWS API reference for the feature.

I'm happy to provide any other information, although I unfortunately do not have any experience in Go. =\

@bflad bflad added service/ec2 Issues and PRs that pertain to the ec2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 4, 2019
@bflad bflad added this to the v2.18.0 milestone Jul 4, 2019
@bflad
Copy link
Contributor

bflad commented Jul 4, 2019

A new blackhole argument for the aws_ec2_transit_gateway_route resource has been merged and will release with version 2.18.0 of the Terraform AWS Provider, likely in the next day. Thanks, @anouvel!

@bflad
Copy link
Contributor

bflad commented Jul 5, 2019

This has been released in version 2.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants