Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Data Source" header to data source resources. #2422

Closed
wants to merge 2 commits into from
Closed

Adding "Data Source" header to data source resources. #2422

wants to merge 2 commits into from

Conversation

RavenAlly
Copy link

@RavenAlly RavenAlly commented Nov 24, 2017

@RavenAlly RavenAlly changed the title Issue #18 - Adding "Data Source" header to data source resources. hashicorp/terraform-website Issue #18 - Adding "Data Source" header to data source resources. Nov 24, 2017
@bflad
Copy link
Contributor

bflad commented Nov 24, 2017

👍 personally. Thank you! Totally not necessary in this PR but it'd be nice to clean up the extraneous slashes in the titles too

@Ninir Ninir changed the title hashicorp/terraform-website Issue #18 - Adding "Data Source" header to data source resources. Adding "Data Source" header to data source resources. Nov 24, 2017
@Ninir Ninir added the documentation Introduces or discusses updates to documentation. label Nov 24, 2017
@Ninir
Copy link
Contributor

Ninir commented Nov 24, 2017

Hi @RavenAlly

I do think this is a good idea to better identify whether you're on a resource or a data source 👍

Since it needs to be reflected among other providers, just would like to call @sethvargo here and know what he thinks of it if you don't mind: perhaps he even has an approach to deal with this :).
Seth manages many things at HashiCorp, but worked a lot on the website, so just wondering!

@catsby
Copy link
Contributor

catsby commented Dec 19, 2017

Thank you! I'm closing this in favor of #2713 that I just opened, it's this PR but with a commit where I merge master and resolve the above merge conflicts.

@catsby catsby closed this Dec 19, 2017
catsby added a commit that referenced this pull request Jan 3, 2018
#2713)

* Add "Data Source:" to main heading of data source resources (issue #18)
catsby added a commit that referenced this pull request Jan 3, 2018
#2713)

* Add "Data Source:" to main heading of data source resources (issue #18)
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants