Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_network_acl: Prevent crash in TestAccAWSNetworkAcl_SubnetChange #4095

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 6, 2018

Old and busted (occasionally):

=== RUN   TestAccAWSNetworkAcl_SubnetChange
--- FAIL: TestAccAWSNetworkAcl_SubnetChange (25.21s)

------- Stderr: -------
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x2507806]

goroutine 22 [running]:
testing.tRunner.func1(0xc4202bd3b0)
    /usr/local/go/src/testing/testing.go:711 +0x2d2
panic(0x2b65040, 0x5218270)
    /usr/local/go/src/runtime/panic.go:491 +0x283
github.com/terraform-providers/terraform-provider-aws/aws.testAccCheckSubnetIsAssociatedWithAcl.func1(0xc4208a42a0, 0xbbc15f, 0xc42094b620)
    /opt/teamcity-agent/work/6025502d125bbe5e/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_network_acl_test.go:506 +0x136

New hotness:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSNetworkAcl_SubnetChange'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSNetworkAcl_SubnetChange -timeout 120m
=== RUN   TestAccAWSNetworkAcl_SubnetChange
--- PASS: TestAccAWSNetworkAcl_SubnetChange (53.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.441s

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. labels Apr 6, 2018
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 6, 2018
@bflad bflad added this to the v1.15.0 milestone Apr 12, 2018
@bflad bflad requested a review from a team April 12, 2018 14:44
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 90a0813 into master Apr 12, 2018
@bflad bflad deleted the t-aws_network_acl-prevent-subnetchange-crash branch April 12, 2018 17:35
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants