re-added tests #5049
Merged
re-added tests #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
tests
bflad
reviewed
Jul 2, 2018
There was a problem hiding this comment.
This is currently not working for me, but it did tease out a Terraform panic that should be fixed
=== RUN TestAccAWSLambdaAlias_routingconfig
panic: interface conversion: interface {} is map[string]interface {}, not float64
goroutine 5188 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.expandFloat64Map(0xc420ba1c20, 0xc420ba1c20)
/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/structure.go:799 +0x1cb
github.com/terraform-providers/terraform-provider-aws/aws.expandLambdaAliasRoutingConfiguration(0xc4207d18a0, 0x1, 0x1, 0x339a8c0)
/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_alias.go:177 +0xc8
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsLambdaAliasCreate(0xc4204f1c70, 0x387fda0, 0xc420c34840, 0xc4204f1c70, 0x0)
/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_lambda_alias.go:76 +0x391
Which can be fixed with:
# inside expandLambdaAliasRoutingConfiguration
if v, ok := m["additional_version_weights"]; ok {
aliasRoutingConfiguration.AdditionalVersionWeights = expandFloat64Map(v.(map[string]interface{}))
}| @@ -78,6 +79,35 @@ func TestAccAWSLambdaAlias_nameupdate(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccAWSLambdaAlias_routingconfig(t *testing.T) { | |||
There was a problem hiding this comment.
This acceptance test is currently failing for me:
make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaAlias_routingconfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaAlias_routingconfig -timeout 120m
=== RUN TestAccAWSLambdaAlias_routingconfig
--- FAIL: TestAccAWSLambdaAlias_routingconfig (86.12s)
testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:
* aws_lambda_alias.lambda_alias_test: 1 error(s) occurred:
* aws_lambda_alias.lambda_alias_test: Error creating Lambda alias: ResourceNotFoundException: Function not found: arn:aws:lambda:us-west-2:187416307283:function:tf_acc_lambda_func_alias_basic_vmhu4b4h:2
status code: 404, request id: 8e743c6f-7e17-11e8-81bb-0f6cecc9e91a
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 86.161s
Its complaining because version 2 of the Lambda function (newly created in the test) does not exist. I'm not sure its possible to create this configuration without at least two versions of the Lambda function existing already. When trying to set the routing configuration in the existing test configuration to:
routing_config = {
additional_version_weights = {
"1" = 0.5
}
}I get:
* aws_lambda_alias.lambda_alias_test: Error creating Lambda alias: InvalidParameterValueException: Invalid function version 1. Function version 1 is already included in routing configuration.
status code: 400, request id: 6f7ccbcf-7e16-11e8-b729-25d25f4dd472
There was a problem hiding this comment.
@bflad my poor merge resulted in this test getting lost sorry.
It creates multiple versions in order for traffic shifting to be possible and tests that the routing config can be added an removed. Acceptance tests passing.
=== RUN TestAccAWSLambdaAlias_routingconfig
--- PASS: TestAccAWSLambdaAlias_routingconfig (74.10s)
PASS
ok github.com/eggsbenjamin/terraform-provider-aws/aws 74.131s
ghost
added
size/M
bflad
added
bug
bflad
approved these changes
Jul 3, 2018
There was a problem hiding this comment.
Thanks so much @eggsbenjamin!! Looks good. 🚀
make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaAlias'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaAlias -timeout 120m
=== RUN TestAccAWSLambdaAlias_basic
--- PASS: TestAccAWSLambdaAlias_basic (33.15s)
=== RUN TestAccAWSLambdaAlias_nameupdate
--- PASS: TestAccAWSLambdaAlias_nameupdate (41.00s)
=== RUN TestAccAWSLambdaAlias_routingconfig
--- PASS: TestAccAWSLambdaAlias_routingconfig (51.19s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 125.391s
| @@ -190,8 +190,8 @@ func expandLambdaAliasRoutingConfiguration(l []interface{}) *lambda.AliasRouting | |||
|
|
|||
| m := l[0].(map[string]interface{}) | |||
|
|
|||
| if _, ok := m["additional_version_weights"]; ok { | |||
| aliasRoutingConfiguration.AdditionalVersionWeights = expandFloat64Map(m) | |||
| if v, ok := m["additional_version_weights"]; ok { | |||
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test got lost when merging with latest master #3316
Re-added.