Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_codebuild_project: Prevent panic with missing environment variable type #5052

Merged
merged 1 commit into from
Jul 2, 2018
Merged

resource/aws_codebuild_project: Prevent panic with missing environment variable type #5052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion aws/resource_aws_codebuild_project.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,12 @@ func resourceAwsCodeBuildProjectEnvironmentHash(v interface{}) int {
for _, e := range environmentVariables {
if e != nil { // Old statefiles might have nil values in them
ev := e.(map[string]interface{})
buf.WriteString(fmt.Sprintf("%s:%s:%s-", ev["name"].(string), ev["type"].(string), ev["value"].(string)))
buf.WriteString(fmt.Sprintf("%s:", ev["name"].(string)))
// type is sometimes not returned by the API
if v, ok := ev["type"]; ok {
buf.WriteString(fmt.Sprintf("%s:", v.(string)))
}
buf.WriteString(fmt.Sprintf("%s-", ev["value"].(string)))
}
}

Expand Down