Fix aws_lambda_event_source_mapping function name flapping #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
reviewed
Aug 6, 2018
| // Using function name or ARN should not be shown as a diff. | ||
| // Try to convert the old and new values from ARN to function name | ||
| oldFunctionName, oldFunctionNameErr := getFunctionNameFromLambdaArn(old) | ||
| newFunctionName, newFunctionNameErr := getFunctionNameFromLambdaArn(old) |
There was a problem hiding this comment.
Should this be getFunctionNameFromLambdaArn(new)?
bflad
added
bug
|
Sorry about that... Reran the tests |
bflad
approved these changes
Aug 29, 2018
There was a problem hiding this comment.
LGTM, thanks @julienduchesne! 🚀
8 tests passed (all tests)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (34.09s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (74.80s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_import (75.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (79.74s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (80.51s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (96.38s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (97.36s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (102.55s)
bflad
added a commit
that referenced
this pull request
Aug 29, 2018
|
This has been released in version 1.34.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went with DiffSupressFunc finally. I thought it was a bit weird to deprecate an argument just to prevent some flapping. Also, there's already a function implemented to get the function name from a lambda ARN
Changes proposed in this pull request:
function_nameargument that tries to convert the old value from ARN to name as well as the new one. This prevents flapping from name to ARN.Output from acceptance testing: