Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix r/s3_bucket_object documentation to show etag inconsistency #5938

Closed
wants to merge 1 commit into from

Conversation

nwalke
Copy link
Contributor

@nwalke nwalke commented Sep 20, 2018

Update docs to explain etag inconsistency

Fixes #5033

Changes proposed in this pull request:

  • Show in docs why etag is not compatible with server_side_encryption

Update doc to explain etag inconsistency
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. labels Sep 20, 2018
@nwalke
Copy link
Contributor Author

nwalke commented Oct 15, 2018

Anything I can do to move this along?

Questions I can answer?

@bflad
Copy link
Contributor

bflad commented Aug 20, 2019

Hi @nwalke 👋 Thank you for submitting this and sorry for the delayed review. 😅

While this documentation change was valid at the time of submission, it appears currently that ETag is compatible with SSE-S3 given the implementation in the likely to be merged #9442 and given the S3 documentation in https://docs.aws.amazon.com/AmazonS3/latest/API/RESTCommonResponseHeaders.html. Since the documentation is being adjusted by implementing the feature itself, we are going to opt to close this for now, but please don't hesitate to submit future contributions. Thanks again.

@bflad bflad closed this Aug 20, 2019
@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_s3_bucket_object: etag can’t be used with any server encryption, but docs mention a different thing
2 participants