Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecs-Add support for ECS IPC Mode/PID Mode #6515

Merged
merged 3 commits into from
Nov 19, 2018

Conversation

sunilkumarmohanty
Copy link
Contributor

Fixes #6511

Changes proposed in this pull request:

  • Feature Request: Support for ECS IPC Mode/PID Mode

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAvailabilityZones -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_basic (20.07s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (20.34s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       20.380s

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 19, 2018
@sunilkumarmohanty sunilkumarmohanty changed the title Ecs Ecs-Add support for ECS IPC Mode/PID Mode Nov 19, 2018
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Nov 19, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed dependencies Used to indicate dependency changes. labels Nov 19, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, @sunilkumarmohanty. Three minor little things then this is good to go.

aws/resource_aws_ecs_task_definition.go Show resolved Hide resolved
aws/resource_aws_ecs_task_definition.go Show resolved Hide resolved
website/docs/r/ecs_task_definition.html.markdown Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 19, 2018
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 19, 2018
@bflad bflad added this to the v1.46.0 milestone Nov 19, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much @sunilkumarmohanty 🚀

--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolumeMinimalConfig (5.39s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskScopedDockerVolume (5.59s)
--- PASS: TestAccAWSEcsTaskDefinition_arrays (5.77s)
--- PASS: TestAccAWSEcsTaskDefinition_withDockerVolume (5.76s)
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (5.75s)
--- PASS: TestAccAWSEcsTaskDefinition_constraint (5.74s)
--- PASS: TestAccAWSEcsTaskDefinition_Tags (16.33s)
--- PASS: TestAccAWSEcsTaskDefinition_basic (19.62s)
--- PASS: TestAccAWSEcsTaskDefinition_changeVolumesForcesNewResource (20.06s)
--- PASS: TestAccAWSEcsTaskDefinition_Inactive (20.41s)
--- PASS: TestAccAWSEcsTaskDefinition_withPidMode (20.53s)
--- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (20.73s)
--- PASS: TestAccAWSEcsTaskDefinition_Fargate (20.62s)
--- PASS: TestAccAWSEcsTaskDefinition_withIPCMode (20.86s)
--- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (21.23s)
--- PASS: TestAccAWSEcsTaskDefinition_withEcsService (34.14s)
--- PASS: TestAccAWSEcsTaskDefinition_ExecutionRole (34.41s)

@bflad bflad merged commit b10a1e9 into hashicorp:master Nov 19, 2018
bflad added a commit that referenced this pull request Nov 19, 2018
@bflad
Copy link
Contributor

bflad commented Nov 20, 2018

This has been released in version 1.46.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for ECS IPC Mode/PID Mode
2 participants