Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS App Mesh GA additions #8119

Merged
merged 3 commits into from
Apr 10, 2019
Merged

AWS App Mesh GA additions #8119

merged 3 commits into from
Apr 10, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8102.

@ghost ghost added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 28, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service. labels Mar 28, 2019
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 29, 2019
@ewbankkit
Copy link
Contributor Author 

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh/Mesh/basic
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualService
=== RUN   TestAccAWSAppmesh/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh/VirtualService/virtualRouter
--- PASS: TestAccAWSAppmesh (303.74s)
    --- PASS: TestAccAWSAppmesh/Mesh (52.14s)
        --- PASS: TestAccAWSAppmesh/Mesh/egressFilter (35.27s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (16.87s)
    --- PASS: TestAccAWSAppmesh/Route (69.19s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (34.73s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (34.46s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (83.09s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (19.63s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (31.76s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (31.70s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (31.85s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (31.85s)
    --- PASS: TestAccAWSAppmesh/VirtualService (67.45s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualNode (34.88s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualRouter (32.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	303.796s

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Mar 31, 2019
@ewbankkit ewbankkit changed the title [WIP] AWS App Mesh GA additions AWS App Mesh GA additions Mar 31, 2019
@ewbankkit
Copy link
Contributor Author

Removed WIP.
Ready for review.

@bflad bflad added this to the v2.6.0 milestone Apr 10, 2019
bflad
bflad approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @ewbankkit, thanks so much! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAppmesh (105.42s)
    --- PASS: TestAccAWSAppmesh/VirtualService (22.87s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualNode (12.00s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualRouter (10.88s)
    --- PASS: TestAccAWSAppmesh/Mesh (20.44s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (6.52s)
        --- PASS: TestAccAWSAppmesh/Mesh/egressFilter (13.92s)
    --- PASS: TestAccAWSAppmesh/Route (21.74s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (10.96s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (10.79s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (29.10s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (6.38s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (10.53s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (12.19s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (11.26s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (11.26s)

@bflad bflad merged commit bcdaaf0 into hashicorp:master Apr 10, 2019
bflad added a commit that referenced this pull request Apr 10, 2019
@bflad
Update CHANGELOG for #8119
25868fb
@bflad
Copy link
Contributor

bflad commented Apr 11, 2019

This has been released in version 2.6.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit deleted the issue-8102 branch April 16, 2019 13:13
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging this pull request may close these issues.

AWS App Mesh GA additions
2 participants
@ewbankkit @bflad