Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/ssm_parameter: Add version as output #9127

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 25, 2019

Fixes: #9104

▶ acctests aws TestAccAWSSsmParameterDataSource_
=== RUN   TestAccAWSSsmParameterDataSource_basic
=== PAUSE TestAccAWSSsmParameterDataSource_basic
=== RUN   TestAccAWSSsmParameterDataSource_fullPath
=== PAUSE TestAccAWSSsmParameterDataSource_fullPath
=== CONT  TestAccAWSSsmParameterDataSource_basic
=== CONT  TestAccAWSSsmParameterDataSource_fullPath
--- PASS: TestAccAWSSsmParameterDataSource_fullPath (36.58s)
--- PASS: TestAccAWSSsmParameterDataSource_basic (57.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.936s
▶ acctests aws TestAccAWSSSMParameter_
=== RUN   TestAccAWSSSMParameter_importBasic
=== PAUSE TestAccAWSSSMParameter_importBasic
=== RUN   TestAccAWSSSMParameter_basic
=== PAUSE TestAccAWSSSMParameter_basic
=== RUN   TestAccAWSSSMParameter_Tier
=== PAUSE TestAccAWSSSMParameter_Tier
=== RUN   TestAccAWSSSMParameter_disappears
=== PAUSE TestAccAWSSSMParameter_disappears
=== RUN   TestAccAWSSSMParameter_overwrite
=== PAUSE TestAccAWSSSMParameter_overwrite
=== RUN   TestAccAWSSSMParameter_updateTags
=== PAUSE TestAccAWSSSMParameter_updateTags
=== RUN   TestAccAWSSSMParameter_updateDescription
=== PAUSE TestAccAWSSSMParameter_updateDescription
=== RUN   TestAccAWSSSMParameter_changeNameForcesNew
=== PAUSE TestAccAWSSSMParameter_changeNameForcesNew
=== RUN   TestAccAWSSSMParameter_fullPath
=== PAUSE TestAccAWSSSMParameter_fullPath
=== RUN   TestAccAWSSSMParameter_secure
=== PAUSE TestAccAWSSSMParameter_secure
=== RUN   TestAccAWSSSMParameter_secure_with_key
=== PAUSE TestAccAWSSSMParameter_secure_with_key
=== RUN   TestAccAWSSSMParameter_secure_keyUpdate
=== PAUSE TestAccAWSSSMParameter_secure_keyUpdate
=== CONT  TestAccAWSSSMParameter_importBasic
=== CONT  TestAccAWSSSMParameter_changeNameForcesNew
=== CONT  TestAccAWSSSMParameter_overwrite
=== CONT  TestAccAWSSSMParameter_disappears
--- PASS: TestAccAWSSSMParameter_disappears (21.59s)
=== CONT  TestAccAWSSSMParameter_updateDescription
--- PASS: TestAccAWSSSMParameter_importBasic (35.16s)
=== CONT  TestAccAWSSSMParameter_Tier
--- PASS: TestAccAWSSSMParameter_overwrite (53.83s)
=== CONT  TestAccAWSSSMParameter_updateTags
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (54.77s)
=== CONT  TestAccAWSSSMParameter_basic
--- PASS: TestAccAWSSSMParameter_updateDescription (51.00s)
=== CONT  TestAccAWSSSMParameter_secure_with_key
--- PASS: TestAccAWSSSMParameter_basic (29.44s)
=== CONT  TestAccAWSSSMParameter_secure_keyUpdate
--- PASS: TestAccAWSSSMParameter_updateTags (53.12s)
=== CONT  TestAccAWSSSMParameter_secure
--- PASS: TestAccAWSSSMParameter_Tier (77.31s)
=== CONT  TestAccAWSSSMParameter_fullPath
--- PASS: TestAccAWSSSMParameter_secure (29.33s)
--- PASS: TestAccAWSSSMParameter_fullPath (30.45s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (74.49s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (98.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	182.479s

Fixes: hashicorp#9104

```
▶ acctests aws TestAccAWSSsmParameterDataSource_
=== RUN   TestAccAWSSsmParameterDataSource_basic
=== PAUSE TestAccAWSSsmParameterDataSource_basic
=== RUN   TestAccAWSSsmParameterDataSource_fullPath
=== PAUSE TestAccAWSSsmParameterDataSource_fullPath
=== CONT  TestAccAWSSsmParameterDataSource_basic
=== CONT  TestAccAWSSsmParameterDataSource_fullPath
--- PASS: TestAccAWSSsmParameterDataSource_fullPath (36.58s)
--- PASS: TestAccAWSSsmParameterDataSource_basic (57.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.936s
```

```
▶ acctests aws TestAccAWSSSMParameter_
=== RUN   TestAccAWSSSMParameter_importBasic
=== PAUSE TestAccAWSSSMParameter_importBasic
=== RUN   TestAccAWSSSMParameter_basic
=== PAUSE TestAccAWSSSMParameter_basic
=== RUN   TestAccAWSSSMParameter_Tier
=== PAUSE TestAccAWSSSMParameter_Tier
=== RUN   TestAccAWSSSMParameter_disappears
=== PAUSE TestAccAWSSSMParameter_disappears
=== RUN   TestAccAWSSSMParameter_overwrite
=== PAUSE TestAccAWSSSMParameter_overwrite
=== RUN   TestAccAWSSSMParameter_updateTags
=== PAUSE TestAccAWSSSMParameter_updateTags
=== RUN   TestAccAWSSSMParameter_updateDescription
=== PAUSE TestAccAWSSSMParameter_updateDescription
=== RUN   TestAccAWSSSMParameter_changeNameForcesNew
=== PAUSE TestAccAWSSSMParameter_changeNameForcesNew
=== RUN   TestAccAWSSSMParameter_fullPath
=== PAUSE TestAccAWSSSMParameter_fullPath
=== RUN   TestAccAWSSSMParameter_secure
=== PAUSE TestAccAWSSSMParameter_secure
=== RUN   TestAccAWSSSMParameter_secure_with_key
=== PAUSE TestAccAWSSSMParameter_secure_with_key
=== RUN   TestAccAWSSSMParameter_secure_keyUpdate
=== PAUSE TestAccAWSSSMParameter_secure_keyUpdate
=== CONT  TestAccAWSSSMParameter_importBasic
=== CONT  TestAccAWSSSMParameter_changeNameForcesNew
=== CONT  TestAccAWSSSMParameter_overwrite
=== CONT  TestAccAWSSSMParameter_disappears
--- PASS: TestAccAWSSSMParameter_disappears (21.59s)
=== CONT  TestAccAWSSSMParameter_updateDescription
--- PASS: TestAccAWSSSMParameter_importBasic (35.16s)
=== CONT  TestAccAWSSSMParameter_Tier
--- PASS: TestAccAWSSSMParameter_overwrite (53.83s)
=== CONT  TestAccAWSSSMParameter_updateTags
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (54.77s)
=== CONT  TestAccAWSSSMParameter_basic
--- PASS: TestAccAWSSSMParameter_updateDescription (51.00s)
=== CONT  TestAccAWSSSMParameter_secure_with_key
--- PASS: TestAccAWSSSMParameter_basic (29.44s)
=== CONT  TestAccAWSSSMParameter_secure_keyUpdate
--- PASS: TestAccAWSSSMParameter_updateTags (53.12s)
=== CONT  TestAccAWSSSMParameter_secure
--- PASS: TestAccAWSSSMParameter_Tier (77.31s)
=== CONT  TestAccAWSSSMParameter_fullPath
--- PASS: TestAccAWSSSMParameter_secure (29.33s)
--- PASS: TestAccAWSSSMParameter_fullPath (30.45s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (74.49s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (98.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	182.479s
```
@stack72 stack72 requested a review from a team June 25, 2019 11:35
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 25, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 26, 2019
@bflad bflad added this to the v2.17.0 milestone Jun 26, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stack72 🚀

--- PASS: TestAWSSSMParameterShouldUpdate (0.00s)
--- PASS: TestAccAWSSSMParameter_disappears (9.79s)
--- PASS: TestAccAWSSSMParameter_fullPath (17.25s)
--- PASS: TestAccAWSSsmParameterDataSource_basic (18.78s)
--- PASS: TestAccAWSSSMParameter_importBasic (21.58s)
--- PASS: TestAccAWSSSMParameter_overwrite (22.58s)
--- PASS: TestAccAWSSSMParameter_secure (23.14s)
--- PASS: TestAccAWSSsmParameterDataSource_fullPath (26.38s)
--- PASS: TestAccAWSSSMParameter_Tier (31.69s)
--- PASS: TestAccAWSSSMParameter_basic (32.32s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (32.78s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (38.81s)
--- PASS: TestAccAWSSSMParameter_updateDescription (39.27s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (39.73s)
--- PASS: TestAccAWSSSMParameter_updateTags (41.33s)

@bflad bflad merged commit 768ca02 into hashicorp:master Jun 27, 2019
bflad added a commit that referenced this pull request Jun 27, 2019
@bflad
Copy link
Contributor

bflad commented Jun 28, 2019

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ssm_parameter: add "version" as output
2 participants