Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudFormation Ordered Sets #89

Closed
ewbankkit opened this issue Aug 10, 2021 · 1 comment · Fixed by #110
Closed

CloudFormation Ordered Sets #89

ewbankkit opened this issue Aug 10, 2021 · 1 comment · Fixed by #110
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime.
Milestone
v0.1.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Aug 10, 2021 •
edited
Loading

CloudFormation properties can be of type ordered set - unique items with insertion order significant. This type does not cleanly map to either Terraform List or Set.

Currently we emit these properties as Lists but we will need to add validation that elements are unique.
Likely best handled via a custom type.

Relates: #39.
Relates: hashicorp/terraform-plugin-framework#99.
@ewbankkit ewbankkit added the code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime. label Aug 10, 2021
@ewbankkit ewbankkit mentioned this issue Aug 10, 2021
Closed
@ewbankkit ewbankkit added this to the v0.2.0 milestone Aug 11, 2021
@ewbankkit ewbankkit mentioned this issue Aug 18, 2021
Merged
@ewbankkit
Copy link
Contributor Author

Actually, best handed with an attribute-level validator.

@breathingdust breathingdust modified the milestones: v0.2.0, v0.1.0 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-generation Relates to the conversion of CloudFormation schema to Terraform schema at buildtime.
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Add UniqueItems attribute validation hashicorp/terraform-provider-awscc
2 participants
@breathingdust @ewbankkit