Workaround: auto-retry when looking for existing service principals, assuming that one is likely to exist when use_existing = true
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
force-pushed
the
bugfix/existing-service-principal-consistency-workaround
branch
from
5d9e699
to
a4434c2
Compare
…assuming that one is likely to exist when `use_existing = true`
manicminer
force-pushed
the
bugfix/existing-service-principal-consistency-workaround
branch
from
a4434c2
to
2170d72
Compare
|
Test results
|
manicminer
added a commit
that referenced
this pull request
Feb 21, 2023
manicminer
deleted the
bugfix/existing-service-principal-consistency-workaround
branch
|
This functionality has been released in v2.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to adopt an existing service principal, through use of
use_existing = true, that was very recently created - for example by instantiating an application template - perform retries when looking up the existing service principal to try and defeat eventual consistency. This is necessary because the 'existing' check requires a List operation with a filter, rather than a typical Get operation.