Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azuread_conditional_access_policy - Add disable_session_resilience property #1135

Merged
merged 1 commit into from
Jul 12, 2023
Merged

azuread_conditional_access_policy - Add disable_session_resilience property #1135

merged 1 commit into from
Jul 12, 2023

Conversation

bubbletroubles
Copy link
Contributor

@bubbletroubles bubbletroubles commented Jul 4, 2023 •
edited
Loading

Adds the disable_session_resilience property in the azuread_conditional_access_policy resource.

Fixes #931

  • Updated docs
  • Updated tests

@bubbletroubles
Copy link
Contributor Author

bubbletroubles commented Jul 4, 2023 •
edited
Loading

Tests are passing

=== RUN   TestAccConditionalAccessPolicy_includedUserActions
=== PAUSE TestAccConditionalAccessPolicy_includedUserActions
=== RUN   TestAccConditionalAccessPolicy_sessionControls
=== PAUSE TestAccConditionalAccessPolicy_sessionControls
=== RUN   TestAccConditionalAccessPolicy_sessionControlsDisabled
=== PAUSE TestAccConditionalAccessPolicy_sessionControlsDisabled
=== CONT  TestAccConditionalAccessPolicy_basic
=== CONT  TestAccConditionalAccessPolicy_sessionControlsDisabled
--- PASS: TestAccConditionalAccessPolicy_basic (200.06s)
=== CONT  TestAccConditionalAccessPolicy_deviceFilter
--- PASS: TestAccConditionalAccessPolicy_sessionControlsDisabled (267.05s)
=== CONT  TestAccConditionalAccessPolicy_sessionControls
--- PASS: TestAccConditionalAccessPolicy_deviceFilter (293.07s)
=== CONT  TestAccConditionalAccessPolicy_includedUserActions
--- PASS: TestAccConditionalAccessPolicy_sessionControls (389.18s)
=== CONT  TestAccConditionalAccessPolicy_update
--- PASS: TestAccConditionalAccessPolicy_includedUserActions (259.96s)
=== CONT  TestAccConditionalAccessPolicy_complete
--- PASS: TestAccConditionalAccessPolicy_update (265.63s)
--- PASS: TestAccConditionalAccessPolicy_complete (195.16s)

manicminer
manicminer approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition @bubbletroubles! This LGTM, I have squashed and recommitted your changes in your name as they originally had Author: Your Name <you@example.com>, hope you don't mind :)

@manicminer
Copy link
Member

Test results

Screenshot 2023-07-13 at 00 27 07

@manicminer manicminer merged commit c9db207 into hashicorp:main Jul 12, 2023
7 checks passed
manicminer added a commit that referenced this pull request Jul 12, 2023
@manicminer
Changelog for #1135
bf0df59
@bubbletroubles bubbletroubles deleted the conditional-access-docs branch July 13, 2023 00:35
manicminer added a commit to pchanvallon/terraform-provider-azuread that referenced this pull request Jul 13, 2023
@manicminer
Changelog for hashicorp#1135
c38e3a2
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
enhancement feature/conditional-access size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(azuread_conditional_access_policy) Support for disableResilienceDefaults
2 participants
@bubbletroubles @manicminer