-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data source directory_role_templates
#1152
data source directory_role_templates
#1152
Conversation
directory_role_templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MattGarnerAWR, thank you for this PR! This is looking great, and I do not have any changes to suggest beyond what the tests have flagged - just a couple questions to clarify before we look to merge this.
internal/services/directoryroles/directory_role_templates_data_source.go
Show resolved
Hide resolved
Thanks @manicminer , I have resolved all of them and hopefully the right package will mean the tests run this time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MattGarnerAWR, just a couple minor tweakd which I've made below but otherwise LGTM 👍
internal/services/directoryroles/directory_role_templates_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_role_templates_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_role_templates_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_role_templates_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_role_templates_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_role_templates_data_source.go
Outdated
Show resolved
Hide resolved
@MattGarnerAWR Just a couple things to note:
I fixed these up in the PR as I didn't spot them earlier on, hope you don't mind. Thanks again for the contribution! |
Thanks for your help! |
This functionality has been released in v2.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
My 1st attempt at a PR to add a new data source for directory role templates :)