Implement conditional access policies guests_or_internal_users #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Work in progress until this PR is merged: manicminer/hamilton#262 |
manicminer
force-pushed
the
bugfix/issue-1136-conditional-access-policies-support-guests-or-external-users
branch
from
e426a21
to
3114125
Compare
manicminer
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
@agileknight Thank you for this addition! I've squashed your commits and rebased for the Hamilton update in main, and with no other changes this LGTM! 🚀
|
Test results (failure unrelated) 
|
manicminer
added a commit
that referenced
this pull request
Oct 27, 2023
dduportal
referenced
this pull request
in jenkins-infra/azure
Oct 30, 2023
<Actions>
<action
id="c2aadc6326b4b0bc58df11ee286b0f67ccdb5888bd77f391e6473570113337ec">
<h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/azuread" updated from "2.44.1" to
"2.45.0" in file ".terraform.lock.hcl"</p>
<details>
<summary>2.45.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.45.0
FEATURES:

*
**New Resource:** `azuread_application_optional_claims`
([#1223](https://github.com/hashicorp/terraform-provider-azuread/issues/1223))

ENHANCEMENTS:

*
`azuread_conditional_access_policy` - improved plan-time validation for
the `session_controls` block
([#1229](hashicorp/terraform-provider-azuread#1229
`azuread_conditional_access_policy` - support for the
`sign_in_frequency_authentication_type` and `sign_in_frequency_interval`
properties in the `session_controls` block
([#1229](hashicorp/terraform-provider-azuread#1229
`azuread_conditional_access_policy` - support for the
`included_guests_or_external_users` and
`excluded_guests_or_external_users` blocks in the `users` block
([#1222](https://github.com/hashicorp/terraform-provider-azuread/issues/1222))

BUG
FIXES:

* `azuread_conditional_access_policy` - removing the
`devices` or `session_controls` blocks will no longer force a new
resource to be created
([#1229](https://github.com/hashicorp/terraform-provider-azuread/issues/1229))


</pre>
</details>
</details>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Fixes #1136, #1196