Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: correctly handle missing question properties for azuread_access_package_assignment_policy #1273

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

manicminer
Copy link
Contributor

Fixes: #1271

@manicminer manicminer force-pushed the bugfix/access-package-policy-schema branch from 6b40e0a to 041fd2c Compare December 14, 2023 15:21
@github-actions github-actions bot added size/M and removed size/XS labels Dec 14, 2023
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer changed the title bugfix: add MinItems validation to Required blocks for azuread_access_package_assignment_policy bugfix: correctly handle missing question properties for azuread_access_package_assignment_policy Dec 14, 2023
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2023-12-14 at 15 25 50

@manicminer manicminer merged commit 7b571a0 into main Dec 14, 2023
15 of 16 checks passed
@manicminer manicminer deleted the bugfix/access-package-policy-schema branch December 14, 2023 15:28
manicminer added a commit that referenced this pull request Dec 14, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Dec 15, 2023
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azuread&#34; updated from &#34;2.46.0&#34; to
&#34;2.47.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.47.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.47.0&#xA;BUG
FIXES:&#xA;&#xA;* `azuread_access_package_assignment_policy` - fix a
potential crash when removing the `question` block
([#1273](hashicorp/terraform-provider-azuread#1273
`data.azuread_named_location` - fix a potential crash if the named
location is not found
([#1274](https://github.com/hashicorp/terraform-provider-azuread/issues/1274))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/942/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider crash - azuread_access_package_assignment_policy
2 participants