Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_user & azuread_users: add lookup by mail_nickname #161

Merged
merged 3 commits into from
Oct 17, 2019
Merged

azuread_user & azuread_users: add lookup by mail_nickname #161

merged 3 commits into from
Oct 17, 2019

Conversation

joakimhellum
Copy link
Contributor

@joakimhellum joakimhellum commented Oct 15, 2019

Fixes #160

Would prefer to do lookup by mail and not mail_nickname, but not sure how to manage the tests for it (because test user don't have mail currently).

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @joakimhellum-in! LGTM 👍

@katbyte katbyte added this to the v0.7.0 milestone Oct 17, 2019
@katbyte katbyte merged commit 40fc897 into hashicorp:master Oct 17, 2019
katbyte added a commit that referenced this pull request Oct 17, 2019
@ghost
Copy link

ghost commented Nov 15, 2019

This has been released in version 0.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support for looking up Guest users
2 participants