Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application & azuread_group: Duplicate name detection #279

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

manicminer
Copy link
Member

  • New property prevent_duplicate_names, defaults to false
  • When true, searches for an existing application / group and errs if one found having the same name
  • For applications, also performs the check on update

Closes: #182, #200

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the location of the helper functions LGTM 👍

azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_group.go Outdated Show resolved Hide resolved
@manicminer
Copy link
Member Author

Tests pass:

Screenshot 2020-06-23 03 08 17
Screenshot 2020-06-23 03 08 02

@manicminer manicminer merged commit d2dfb01 into master Jun 23, 2020
@manicminer manicminer deleted the duplicate-name-detection branch June 23, 2020 02:19
manicminer added a commit that referenced this pull request Jun 23, 2020
@ghost
Copy link

ghost commented Jul 9, 2020

This has been released in version 0.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants