Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_application: enable removal of owners #355

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

manicminer
Copy link
Contributor

Enables removal of owners on existing applications, and creation of applications with no owners (by default a new application gets the creator assigned as a single owner).

Closes: #352
Closes: #353

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 871cb51 into master Nov 19, 2020
manicminer added a commit that referenced this pull request Nov 19, 2020
@manicminer manicminer deleted the bug/application-owners-removal branch November 19, 2020 12:03
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 1.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.1.0"
}
# ... other configuration ...

manicminer added a commit that referenced this pull request Nov 26, 2020
manicminer added a commit that referenced this pull request Nov 26, 2020
…ult-owner

azuread_application: revert #355 but retain tests, must retain default application owner at create time
@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants